commit c241022ab4254ad66b5652010c06bf983f75d7c1
author Peter Anvin <hpa@tazenda.(none)> Thu Dec 08 14:54:49 2005 -0800
committer Peter Anvin <hpa@tazenda.(none)> Thu Dec 08 14:54:49 2005 -0800
tree 1a2a6bbee1b4397b51800c82c7d9cff911e77c0a
parent a9d918f61492b91efd89dc8119a57a1a010e5376

Don't hold the cache lock while freeing an old entry.

gencache.pl

diff --git a/gencache.pl b/gencache.pl
index fdedae6..0d7bb18 100755
--- a/gencache.pl
+++ b/gencache.pl
@@ -61,15 +61,19 @@
 
 print GEN "\tunlock_cache(r); \\\n";
 print GEN "\tucd = _libucd_character_data_raw(u); \\\n";
-print GEN "\tlock_cache(r); \\\n";
-print GEN "\tif ( r->e[$maxent].ucd ) \\\n";
-print GEN "\t\tunicode_character_put(r->e[$maxent].ucd); \\\n";
+print GEN "\t{ \\\n";
+print GEN "\t\tconst struct unicode_character_data *olducd; \\\n";
+print GEN "\t\tlock_cache(r); \\\n";
+print GEN "\t\tolducd = r->e[$maxent].ucd; \\\n";
 for ( $j = $maxent ; $j > 0 ; $j-- ) {
     $jm1 = $j-1;
-    print GEN "\tr->e[$j] = r->e[$jm1]; \\\n";
+    print GEN "\t\tr->e[$j] = r->e[$jm1]; \\\n";
 }
-print GEN "\tr->e[0].ucs = u; r->e[0].ucd = ucd; \\\n";
-print GEN "\tunlock_cache(r); \\\n";
+print GEN "\t\tr->e[0].ucs = u; r->e[0].ucd = ucd; \\\n";
+print GEN "\t\tunlock_cache(r); \\\n";
+print GEN "\t\tif (olducd) \\\n";
+print GEN "\t\t\tunicode_character_put(olducd); \\\n";
+print GEN "\t} \\\n";
 print GEN "\treturn ucd; \\\n";
 print GEN "\n";