| From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com> |
| Subject: mm/vma: rename __mmap_prepare() function to avoid confusion |
| Date: Mon, 20 Oct 2025 13:11:23 +0100 |
| |
| Now we have the f_op->mmap_prepare() hook, having a static function called |
| __mmap_prepare() that has nothing to do with it is confusing, so rename |
| the function to __mmap_setup(). |
| |
| Link: https://lkml.kernel.org/r/d25a22c60ca0f04091697ef9cda0d72ce0cf8af3.1760959442.git.lorenzo.stoakes@oracle.com |
| Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com> |
| Reviewed-by: David Hildenbrand <david@redhat.com> |
| Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> |
| Reviewed-by: Pedro Falcato <pfalcato@suse.de> |
| Cc: Alexander Gordeev <agordeev@linux.ibm.com> |
| Cc: Al Viro <viro@zeniv.linux.org.uk> |
| Cc: Andreas Larsson <andreas@gaisler.com> |
| Cc: Andrey Konovalov <andreyknvl@gmail.com> |
| Cc: Arnd Bergmann <arnd@arndb.de> |
| Cc: Baolin Wang <baolin.wang@linux.alibaba.com> |
| Cc: Baoquan He <bhe@redhat.com> |
| Cc: Chatre, Reinette <reinette.chatre@intel.com> |
| Cc: Christian Borntraeger <borntraeger@linux.ibm.com> |
| Cc: Christian Brauner <brauner@kernel.org> |
| Cc: Dan Williams <dan.j.williams@intel.com> |
| Cc: Dave Jiang <dave.jiang@intel.com> |
| Cc: Dave Martin <dave.martin@arm.com> |
| Cc: Dave Young <dyoung@redhat.com> |
| Cc: David S. Miller <davem@davemloft.net> |
| Cc: Dmitriy Vyukov <dvyukov@google.com> |
| Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Cc: Guo Ren <guoren@kernel.org> |
| Cc: Heiko Carstens <hca@linux.ibm.com> |
| Cc: Hugh Dickins <hughd@google.com> |
| Cc: James Morse <james.morse@arm.com> |
| Cc: Jan Kara <jack@suse.cz> |
| Cc: Jann Horn <jannh@google.com> |
| Cc: Jonathan Corbet <corbet@lwn.net> |
| Cc: Kevin Tian <kevin.tian@intel.com> |
| Cc: Konstantin Komarov <almaz.alexandrovich@paragon-software.com> |
| Cc: Liam Howlett <liam.howlett@oracle.com> |
| Cc: "Luck, Tony" <tony.luck@intel.com> |
| Cc: Matthew Wilcox (Oracle) <willy@infradead.org> |
| Cc: Michal Hocko <mhocko@suse.com> |
| Cc: Mike Rapoport <rppt@kernel.org> |
| Cc: Muchun Song <muchun.song@linux.dev> |
| Cc: Nicolas Pitre <nico@fluxnic.net> |
| Cc: Oscar Salvador <osalvador@suse.de> |
| Cc: Robin Murohy <robin.murphy@arm.com> |
| Cc: Sumanth Korikkar <sumanthk@linux.ibm.com> |
| Cc: Suren Baghdasaryan <surenb@google.com> |
| Cc: Sven Schnelle <svens@linux.ibm.com> |
| Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> |
| Cc: "Uladzislau Rezki (Sony)" <urezki@gmail.com> |
| Cc: Vasily Gorbik <gor@linux.ibm.com> |
| Cc: Vishal Verma <vishal.l.verma@intel.com> |
| Cc: Vivek Goyal <vgoyal@redhat.com> |
| Cc: Vlastimil Babka <vbabka@suse.cz> |
| Cc: Will Deacon <will@kernel.org> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| mm/vma.c | 8 ++++---- |
| 1 file changed, 4 insertions(+), 4 deletions(-) |
| |
| --- a/mm/vma.c~mm-vma-rename-__mmap_prepare-function-to-avoid-confusion |
| +++ a/mm/vma.c |
| @@ -2312,7 +2312,7 @@ static void update_ksm_flags(struct mmap |
| } |
| |
| /* |
| - * __mmap_prepare() - Prepare to gather any overlapping VMAs that need to be |
| + * __mmap_setup() - Prepare to gather any overlapping VMAs that need to be |
| * unmapped once the map operation is completed, check limits, account mapping |
| * and clean up any pre-existing VMAs. |
| * |
| @@ -2321,7 +2321,7 @@ static void update_ksm_flags(struct mmap |
| * |
| * Returns: 0 on success, error code otherwise. |
| */ |
| -static int __mmap_prepare(struct mmap_state *map, struct list_head *uf) |
| +static int __mmap_setup(struct mmap_state *map, struct list_head *uf) |
| { |
| int error; |
| struct vma_iterator *vmi = map->vmi; |
| @@ -2632,7 +2632,7 @@ static unsigned long __mmap_region(struc |
| |
| map.check_ksm_early = can_set_ksm_flags_early(&map); |
| |
| - error = __mmap_prepare(&map, uf); |
| + error = __mmap_setup(&map, uf); |
| if (!error && have_mmap_prepare) |
| error = call_mmap_prepare(&map); |
| if (error) |
| @@ -2662,7 +2662,7 @@ static unsigned long __mmap_region(struc |
| |
| return addr; |
| |
| - /* Accounting was done by __mmap_prepare(). */ |
| + /* Accounting was done by __mmap_setup(). */ |
| unacct_error: |
| if (map.charged) |
| vm_unacct_memory(map.charged); |
| _ |