| From: Nathan Chancellor <nathan@kernel.org> |
| Subject: arch and include: update LLVM Phabricator links |
| Date: Tue, 09 Jan 2024 15:16:30 -0700 |
| |
| reviews.llvm.org was LLVM's Phabricator instances for code review. It has |
| been abandoned in favor of GitHub pull requests. While the majority of |
| links in the kernel sources still work because of the work Fangrui has |
| done turning the dynamic Phabricator instance into a static archive, there |
| are some issues with that work, so preemptively convert all the links in |
| the kernel sources to point to the commit on GitHub. |
| |
| Most of the commits have the corresponding differential review link in the |
| commit message itself so there should not be any loss of fidelity in the |
| relevant information. |
| |
| Link: https://discourse.llvm.org/t/update-on-github-pull-requests/71540/172 |
| Link: https://lkml.kernel.org/r/20240109-update-llvm-links-v1-2-eb09b59db071@kernel.org |
| Signed-off-by: Nathan Chancellor <nathan@kernel.org> |
| Reviewed-by: Conor Dooley <conor.dooley@microchip.com> |
| Reviewed-by: Kees Cook <keescook@chromium.org> |
| Acked-by: Fangrui Song <maskray@google.com> |
| Cc: Alexei Starovoitov <ast@kernel.org> |
| Cc: Andrii Nakryiko <andrii@kernel.org> |
| Cc: Daniel Borkmann <daniel@iogearbox.net> |
| Cc: Mykola Lysenko <mykolal@fb.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| arch/arm64/Kconfig | 4 ++-- |
| arch/riscv/Kconfig | 2 +- |
| arch/riscv/include/asm/ftrace.h | 2 +- |
| include/linux/compiler-clang.h | 2 +- |
| 4 files changed, 5 insertions(+), 5 deletions(-) |
| |
| --- a/arch/arm64/Kconfig~arch-and-include-update-llvm-phabricator-links |
| +++ a/arch/arm64/Kconfig |
| @@ -382,7 +382,7 @@ config BROKEN_GAS_INST |
| config BUILTIN_RETURN_ADDRESS_STRIPS_PAC |
| bool |
| # Clang's __builtin_return_adddress() strips the PAC since 12.0.0 |
| - # https://reviews.llvm.org/D75044 |
| + # https://github.com/llvm/llvm-project/commit/2a96f47c5ffca84cd774ad402cacd137f4bf45e2 |
| default y if CC_IS_CLANG && (CLANG_VERSION >= 120000) |
| # GCC's __builtin_return_address() strips the PAC since 11.1.0, |
| # and this was backported to 10.2.0, 9.4.0, 8.5.0, but not earlier |
| @@ -2222,7 +2222,7 @@ config STACKPROTECTOR_PER_TASK |
| |
| config UNWIND_PATCH_PAC_INTO_SCS |
| bool "Enable shadow call stack dynamically using code patching" |
| - # needs Clang with https://reviews.llvm.org/D111780 incorporated |
| + # needs Clang with https://github.com/llvm/llvm-project/commit/de07cde67b5d205d58690be012106022aea6d2b3 incorporated |
| depends on CC_IS_CLANG && CLANG_VERSION >= 150000 |
| depends on ARM64_PTR_AUTH_KERNEL && CC_HAS_BRANCH_PROT_PAC_RET |
| depends on SHADOW_CALL_STACK |
| --- a/arch/riscv/include/asm/ftrace.h~arch-and-include-update-llvm-phabricator-links |
| +++ a/arch/riscv/include/asm/ftrace.h |
| @@ -15,7 +15,7 @@ |
| |
| /* |
| * Clang prior to 13 had "mcount" instead of "_mcount": |
| - * https://reviews.llvm.org/D98881 |
| + * https://github.com/llvm/llvm-project/commit/ef58ae86ba778ed7d01cd3f6bd6d08f943abab44 |
| */ |
| #if defined(CONFIG_CC_IS_GCC) || CONFIG_CLANG_VERSION >= 130000 |
| #define MCOUNT_NAME _mcount |
| --- a/arch/riscv/Kconfig~arch-and-include-update-llvm-phabricator-links |
| +++ a/arch/riscv/Kconfig |
| @@ -312,7 +312,7 @@ config AS_HAS_INSN |
| def_bool $(as-instr,.insn r 51$(comma) 0$(comma) 0$(comma) t0$(comma) t0$(comma) zero) |
| |
| config AS_HAS_OPTION_ARCH |
| - # https://reviews.llvm.org/D123515 |
| + # https://github.com/llvm/llvm-project/commit/9e8ed3403c191ab9c4903e8eeb8f732ff8a43cb4 |
| def_bool y |
| depends on $(as-instr, .option arch$(comma) +m) |
| depends on !$(as-instr, .option arch$(comma) -i) |
| --- a/include/linux/compiler-clang.h~arch-and-include-update-llvm-phabricator-links |
| +++ a/include/linux/compiler-clang.h |
| @@ -9,7 +9,7 @@ |
| * Clang prior to 17 is being silly and considers many __cleanup() variables |
| * as unused (because they are, their sole purpose is to go out of scope). |
| * |
| - * https://reviews.llvm.org/D152180 |
| + * https://github.com/llvm/llvm-project/commit/877210faa447f4cc7db87812f8ed80e398fedd61 |
| */ |
| #undef __cleanup |
| #define __cleanup(func) __maybe_unused __attribute__((__cleanup__(func))) |
| _ |