| From: "Vishal Moola (Oracle)" <vishal.moola@gmail.com> |
| Subject: arm64: convert various functions to use ptdescs |
| Date: Mon, 7 Aug 2023 16:05:00 -0700 |
| |
| As part of the conversions to replace pgtable constructor/destructors with |
| ptdesc equivalents, convert various page table functions to use ptdescs. |
| |
| Link: https://lkml.kernel.org/r/20230807230513.102486-19-vishal.moola@gmail.com |
| Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com> |
| Acked-by: Mike Rapoport (IBM) <rppt@kernel.org> |
| Acked-by: Catalin Marinas <catalin.marinas@arm.com> |
| Cc: Arnd Bergmann <arnd@arndb.de> |
| Cc: Christophe Leroy <christophe.leroy@csgroup.eu> |
| Cc: Claudio Imbrenda <imbrenda@linux.ibm.com> |
| Cc: Dave Hansen <dave.hansen@linux.intel.com> |
| Cc: David Hildenbrand <david@redhat.com> |
| Cc: "David S. Miller" <davem@davemloft.net> |
| Cc: Dinh Nguyen <dinguyen@kernel.org> |
| Cc: Geert Uytterhoeven <geert@linux-m68k.org> |
| Cc: Geert Uytterhoeven <geert+renesas@glider.be> |
| Cc: Guo Ren <guoren@kernel.org> |
| Cc: Huacai Chen <chenhuacai@kernel.org> |
| Cc: Hugh Dickins <hughd@google.com> |
| Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> |
| Cc: Jonas Bonn <jonas@southpole.se> |
| Cc: Matthew Wilcox <willy@infradead.org> |
| Cc: Palmer Dabbelt <palmer@rivosinc.com> |
| Cc: Paul Walmsley <paul.walmsley@sifive.com> |
| Cc: Richard Weinberger <richard@nod.at> |
| Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> |
| Cc: Yoshinori Sato <ysato@users.sourceforge.jp> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| arch/arm64/include/asm/tlb.h | 14 ++++++++------ |
| arch/arm64/mm/mmu.c | 7 ++++--- |
| 2 files changed, 12 insertions(+), 9 deletions(-) |
| |
| --- a/arch/arm64/include/asm/tlb.h~arm64-convert-various-functions-to-use-ptdescs |
| +++ a/arch/arm64/include/asm/tlb.h |
| @@ -75,18 +75,20 @@ static inline void tlb_flush(struct mmu_ |
| static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte, |
| unsigned long addr) |
| { |
| - pgtable_pte_page_dtor(pte); |
| - tlb_remove_table(tlb, pte); |
| + struct ptdesc *ptdesc = page_ptdesc(pte); |
| + |
| + pagetable_pte_dtor(ptdesc); |
| + tlb_remove_ptdesc(tlb, ptdesc); |
| } |
| |
| #if CONFIG_PGTABLE_LEVELS > 2 |
| static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmdp, |
| unsigned long addr) |
| { |
| - struct page *page = virt_to_page(pmdp); |
| + struct ptdesc *ptdesc = virt_to_ptdesc(pmdp); |
| |
| - pgtable_pmd_page_dtor(page); |
| - tlb_remove_table(tlb, page); |
| + pagetable_pmd_dtor(ptdesc); |
| + tlb_remove_ptdesc(tlb, ptdesc); |
| } |
| #endif |
| |
| @@ -94,7 +96,7 @@ static inline void __pmd_free_tlb(struct |
| static inline void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pudp, |
| unsigned long addr) |
| { |
| - tlb_remove_table(tlb, virt_to_page(pudp)); |
| + tlb_remove_ptdesc(tlb, virt_to_ptdesc(pudp)); |
| } |
| #endif |
| |
| --- a/arch/arm64/mm/mmu.c~arm64-convert-various-functions-to-use-ptdescs |
| +++ a/arch/arm64/mm/mmu.c |
| @@ -426,6 +426,7 @@ static phys_addr_t __pgd_pgtable_alloc(i |
| static phys_addr_t pgd_pgtable_alloc(int shift) |
| { |
| phys_addr_t pa = __pgd_pgtable_alloc(shift); |
| + struct ptdesc *ptdesc = page_ptdesc(phys_to_page(pa)); |
| |
| /* |
| * Call proper page table ctor in case later we need to |
| @@ -433,12 +434,12 @@ static phys_addr_t pgd_pgtable_alloc(int |
| * this pre-allocated page table. |
| * |
| * We don't select ARCH_ENABLE_SPLIT_PMD_PTLOCK if pmd is |
| - * folded, and if so pgtable_pmd_page_ctor() becomes nop. |
| + * folded, and if so pagetable_pte_ctor() becomes nop. |
| */ |
| if (shift == PAGE_SHIFT) |
| - BUG_ON(!pgtable_pte_page_ctor(phys_to_page(pa))); |
| + BUG_ON(!pagetable_pte_ctor(ptdesc)); |
| else if (shift == PMD_SHIFT) |
| - BUG_ON(!pgtable_pmd_page_ctor(phys_to_page(pa))); |
| + BUG_ON(!pagetable_pmd_ctor(ptdesc)); |
| |
| return pa; |
| } |
| _ |