| From: "Matthew Wilcox (Oracle)" <willy@infradead.org> |
| Subject: dax: remove access to page->index |
| Date: Mon, 16 Dec 2024 15:53:55 +0000 |
| |
| This looks like a complete mess (why are we setting page->index at page |
| fault time?), but I no longer care about DAX, and there's no reason to let |
| DAX hold us back from removing page->index. |
| |
| Link: https://lkml.kernel.org/r/20241216155408.8102-1-willy@infradead.org |
| Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> |
| Reviewed-by: Jane Chu <jane.chu@oracle.com> |
| Reviewed-by: Dan Williams <dan.j.williams@intel.com> |
| Cc: Alistair Popple <apopple@nvidia.com> |
| Cc: Dave Jiang <dave.jiang@intel.com> |
| Cc: Vishal Verma <vishal.l.verma@intel.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| drivers/dax/device.c | 9 ++++----- |
| 1 file changed, 4 insertions(+), 5 deletions(-) |
| |
| --- a/drivers/dax/device.c~dax-remove-access-to-page-index |
| +++ a/drivers/dax/device.c |
| @@ -89,14 +89,13 @@ static void dax_set_mapping(struct vm_fa |
| ALIGN_DOWN(vmf->address, fault_size)); |
| |
| for (i = 0; i < nr_pages; i++) { |
| - struct page *page = pfn_to_page(pfn_t_to_pfn(pfn) + i); |
| + struct folio *folio = pfn_folio(pfn_t_to_pfn(pfn) + i); |
| |
| - page = compound_head(page); |
| - if (page->mapping) |
| + if (folio->mapping) |
| continue; |
| |
| - page->mapping = filp->f_mapping; |
| - page->index = pgoff + i; |
| + folio->mapping = filp->f_mapping; |
| + folio->index = pgoff + i; |
| } |
| } |
| |
| _ |
