| From: Christoph Hellwig <hch@lst.de> |
| Subject: hfs: remove ->writepage |
| Date: Fri, 2 Dec 2022 11:26:40 +0100 |
| |
| ->writepage is a very inefficient method to write back data, and only |
| used through write_cache_pages or a a fallback when no ->migrate_folio |
| method is present. |
| |
| Set ->migrate_folio to the generic buffer_head based helper, and stop |
| wiring up ->writepage for hfs_aops. |
| |
| Link: https://lkml.kernel.org/r/20221202102644.770505-4-hch@lst.de |
| Signed-off-by: Christoph Hellwig <hch@lst.de> |
| Acked-by: Johannes Weiner <hannes@cmpxchg.org> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| fs/hfs/inode.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/hfs/inode.c~hfs-remove-writepage |
| +++ a/fs/hfs/inode.c |
| @@ -173,12 +173,12 @@ const struct address_space_operations hf |
| .dirty_folio = block_dirty_folio, |
| .invalidate_folio = block_invalidate_folio, |
| .read_folio = hfs_read_folio, |
| - .writepage = hfs_writepage, |
| .write_begin = hfs_write_begin, |
| .write_end = generic_write_end, |
| .bmap = hfs_bmap, |
| .direct_IO = hfs_direct_IO, |
| .writepages = hfs_writepages, |
| + .migrate_folio = buffer_migrate_folio, |
| }; |
| |
| /* |
| _ |
