| From: Nathan Chancellor <nathan@kernel.org> |
| Subject: kasan: Mark unpoison_slab_object() as static |
| Date: Thu, 21 Dec 2023 19:00:42 +0100 |
| |
| With -Wmissing-prototypes enabled, there is a warning that |
| unpoison_slab_object() has no prototype, breaking the build with |
| CONFIG_WERROR=y: |
| |
| mm/kasan/common.c:271:6: error: no previous prototype for 'unpoison_slab_object' [-Werror=missing-prototypes] |
| 271 | void unpoison_slab_object(struct kmem_cache *cache, void *object, gfp_t flags, |
| | ^~~~~~~~~~~~~~~~~~~~ |
| cc1: all warnings being treated as errors |
| |
| Mark the function as static, as it is not used outside of this |
| translation unit, clearing up the warning. |
| |
| Link: https://lkml.kernel.org/r/20231221180042.104694-1-andrey.konovalov@linux.dev |
| Fixes: 3f38c3c5bc40 ("kasan: save alloc stack traces for mempool") |
| Signed-off-by: Nathan Chancellor <nathan@kernel.org> |
| Signed-off-by: Andrey Konovalov <andreyknvl@google.com> |
| Reviewed-by: Marco Elver <elver@google.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| mm/kasan/common.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/mm/kasan/common.c~kasan-save-alloc-stack-traces-for-mempool-fix |
| +++ a/mm/kasan/common.c |
| @@ -277,8 +277,8 @@ void __kasan_kfree_large(void *ptr, unsi |
| /* The object will be poisoned by kasan_poison_pages(). */ |
| } |
| |
| -void unpoison_slab_object(struct kmem_cache *cache, void *object, gfp_t flags, |
| - bool init) |
| +static inline void unpoison_slab_object(struct kmem_cache *cache, void *object, |
| + gfp_t flags, bool init) |
| { |
| /* |
| * Unpoison the whole object. For kmalloc() allocations, |
| _ |
