| From: Ilya Leoshkevich <iii@linux.ibm.com> |
| Subject: kmsan: do not pass NULL pointers as 0 |
| Date: Thu, 27 Jun 2024 16:57:47 +0200 |
| |
| sparse complains about passing NULL pointers as 0. Fix all instances. |
| |
| Link: https://lkml.kernel.org/r/20240627145754.27333-3-iii@linux.ibm.com |
| Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com> |
| Reported-by: kernel test robot <lkp@intel.com> |
| Closes: https://lore.kernel.org/oe-kbuild-all/202406272033.KejtfLkw-lkp@intel.com/ |
| Reviewed-by: Alexander Potapenko <glider@google.com> |
| Cc: Dmitry Vyukov <dvyukov@google.com> |
| Cc: Marco Elver <elver@google.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| mm/kmsan/hooks.c | 15 ++++++++------- |
| mm/kmsan/instrumentation.c | 4 ++-- |
| 2 files changed, 10 insertions(+), 9 deletions(-) |
| |
| --- a/mm/kmsan/hooks.c~kmsan-do-not-pass-null-pointers-as-0 |
| +++ a/mm/kmsan/hooks.c |
| @@ -303,7 +303,8 @@ void kmsan_handle_urb(const struct urb * |
| if (is_out) |
| kmsan_internal_check_memory(urb->transfer_buffer, |
| urb->transfer_buffer_length, |
| - /*user_addr*/ 0, REASON_SUBMIT_URB); |
| + /*user_addr*/ NULL, |
| + REASON_SUBMIT_URB); |
| else |
| kmsan_internal_unpoison_memory(urb->transfer_buffer, |
| urb->transfer_buffer_length, |
| @@ -316,14 +317,14 @@ static void kmsan_handle_dma_page(const |
| { |
| switch (dir) { |
| case DMA_BIDIRECTIONAL: |
| - kmsan_internal_check_memory((void *)addr, size, /*user_addr*/ 0, |
| - REASON_ANY); |
| + kmsan_internal_check_memory((void *)addr, size, |
| + /*user_addr*/ NULL, REASON_ANY); |
| kmsan_internal_unpoison_memory((void *)addr, size, |
| /*checked*/ false); |
| break; |
| case DMA_TO_DEVICE: |
| - kmsan_internal_check_memory((void *)addr, size, /*user_addr*/ 0, |
| - REASON_ANY); |
| + kmsan_internal_check_memory((void *)addr, size, |
| + /*user_addr*/ NULL, REASON_ANY); |
| break; |
| case DMA_FROM_DEVICE: |
| kmsan_internal_unpoison_memory((void *)addr, size, |
| @@ -418,8 +419,8 @@ void kmsan_check_memory(const void *addr |
| { |
| if (!kmsan_enabled) |
| return; |
| - return kmsan_internal_check_memory((void *)addr, size, /*user_addr*/ 0, |
| - REASON_ANY); |
| + return kmsan_internal_check_memory((void *)addr, size, |
| + /*user_addr*/ NULL, REASON_ANY); |
| } |
| EXPORT_SYMBOL(kmsan_check_memory); |
| |
| --- a/mm/kmsan/instrumentation.c~kmsan-do-not-pass-null-pointers-as-0 |
| +++ a/mm/kmsan/instrumentation.c |
| @@ -315,8 +315,8 @@ void __msan_warning(u32 origin) |
| if (!kmsan_enabled || kmsan_in_runtime()) |
| return; |
| kmsan_enter_runtime(); |
| - kmsan_report(origin, /*address*/ 0, /*size*/ 0, |
| - /*off_first*/ 0, /*off_last*/ 0, /*user_addr*/ 0, |
| + kmsan_report(origin, /*address*/ NULL, /*size*/ 0, |
| + /*off_first*/ 0, /*off_last*/ 0, /*user_addr*/ NULL, |
| REASON_ANY); |
| kmsan_leave_runtime(); |
| } |
| _ |