| From: Florent Revest <revest@chromium.org> |
| Subject: kselftest: vm: check errnos in mdwe_test |
| Date: Mon, 28 Aug 2023 17:08:55 +0200 |
| |
| Invalid prctls return a negative code and set errno. It's good practice |
| to check that errno is set as expected. |
| |
| Link: https://lkml.kernel.org/r/20230828150858.393570-4-revest@chromium.org |
| Signed-off-by: Florent Revest <revest@chromium.org> |
| Reviewed-by: Kees Cook <keescook@chromium.org> |
| Acked-by: Catalin Marinas <catalin.marinas@arm.com> |
| Cc: Alexey Izbyshev <izbyshev@ispras.ru> |
| Cc: Anshuman Khandual <anshuman.khandual@arm.com> |
| Cc: Ayush Jain <ayush.jain3@amd.com> |
| Cc: David Hildenbrand <david@redhat.com> |
| Cc: Greg Thelen <gthelen@google.com> |
| Cc: Joey Gouly <joey.gouly@arm.com> |
| Cc: KP Singh <kpsingh@kernel.org> |
| Cc: Mark Brown <broonie@kernel.org> |
| Cc: Michal Hocko <mhocko@suse.com> |
| Cc: Peter Xu <peterx@redhat.com> |
| Cc: Ryan Roberts <ryan.roberts@arm.com> |
| Cc: Szabolcs Nagy <Szabolcs.Nagy@arm.com> |
| Cc: Topi Miettinen <toiwoton@gmail.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| tools/testing/selftests/mm/mdwe_test.c | 8 ++++++++ |
| 1 file changed, 8 insertions(+) |
| |
| --- a/tools/testing/selftests/mm/mdwe_test.c~kselftest-vm-check-errnos-in-mdwe_test |
| +++ a/tools/testing/selftests/mm/mdwe_test.c |
| @@ -23,14 +23,22 @@ |
| TEST(prctl_flags) |
| { |
| EXPECT_LT(prctl(PR_SET_MDWE, 7L, 0L, 0L, 0L), 0); |
| + EXPECT_EQ(errno, EINVAL); |
| EXPECT_LT(prctl(PR_SET_MDWE, 0L, 7L, 0L, 0L), 0); |
| + EXPECT_EQ(errno, EINVAL); |
| EXPECT_LT(prctl(PR_SET_MDWE, 0L, 0L, 7L, 0L), 0); |
| + EXPECT_EQ(errno, EINVAL); |
| EXPECT_LT(prctl(PR_SET_MDWE, 0L, 0L, 0L, 7L), 0); |
| + EXPECT_EQ(errno, EINVAL); |
| |
| EXPECT_LT(prctl(PR_GET_MDWE, 7L, 0L, 0L, 0L), 0); |
| + EXPECT_EQ(errno, EINVAL); |
| EXPECT_LT(prctl(PR_GET_MDWE, 0L, 7L, 0L, 0L), 0); |
| + EXPECT_EQ(errno, EINVAL); |
| EXPECT_LT(prctl(PR_GET_MDWE, 0L, 0L, 7L, 0L), 0); |
| + EXPECT_EQ(errno, EINVAL); |
| EXPECT_LT(prctl(PR_GET_MDWE, 0L, 0L, 0L, 7L), 0); |
| + EXPECT_EQ(errno, EINVAL); |
| } |
| |
| FIXTURE(mdwe) |
| _ |