| From: Kuan-Wei Chiu <visitorckw@gmail.com> |
| Subject: lib/Makefile: make union-find compilation conditional on CONFIG_CPUSETS |
| Date: Fri, 11 Oct 2024 22:12:14 +0800 |
| |
| Currently, cpuset is the only user of the union-find implementation. |
| Compiling union-find in all configurations unnecessarily increases the |
| code size when building the kernel without cgroup support. Modify the |
| build system to compile union-find only when CONFIG_CPUSETS is enabled. |
| |
| Link: https://lore.kernel.org/lkml/1ccd6411-5002-4574-bb8e-3e64bba6a757@redhat.com/ |
| Link: https://lkml.kernel.org/r/20241011141214.87096-1-visitorckw@gmail.com |
| Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com> |
| Suggested-by: Waiman Long <llong@redhat.com> |
| Acked-by: Waiman Long <longman@redhat.com> |
| Acked-by: Tejun Heo <tj@kernel.org> |
| Reviewed-by: Christoph Hellwig <hch@lst.de> |
| Cc: Ching-Chun (Jim) Huang <jserv@ccns.ncku.edu.tw> |
| Cc: Johannes Weiner <hannes@cmpxchg.org> |
| Cc: Michal Koutný <mkoutny@suse.com> |
| Cc: Xavier <xavier_qy@163.com> |
| Cc: Zefan Li <lizefan.x@bytedance.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| init/Kconfig | 1 + |
| lib/Kconfig | 3 +++ |
| lib/Makefile | 3 ++- |
| 3 files changed, 6 insertions(+), 1 deletion(-) |
| |
| --- a/init/Kconfig~lib-makefile-make-union-find-compilation-conditional-on-config_cpusets |
| +++ a/init/Kconfig |
| @@ -1157,6 +1157,7 @@ config CGROUP_HUGETLB |
| config CPUSETS |
| bool "Cpuset controller" |
| depends on SMP |
| + select UNION_FIND |
| help |
| This option will let you create and manage CPUSETs which |
| allow dynamically partitioning a system into sets of CPUs and |
| --- a/lib/Kconfig~lib-makefile-make-union-find-compilation-conditional-on-config_cpusets |
| +++ a/lib/Kconfig |
| @@ -777,3 +777,6 @@ config POLYNOMIAL |
| |
| config FIRMWARE_TABLE |
| bool |
| + |
| +config UNION_FIND |
| + bool |
| --- a/lib/Makefile~lib-makefile-make-union-find-compilation-conditional-on-config_cpusets |
| +++ a/lib/Makefile |
| @@ -35,8 +35,9 @@ lib-y := ctype.o string.o vsprintf.o cmd |
| is_single_threaded.o plist.o decompress.o kobject_uevent.o \ |
| earlycpio.o seq_buf.o siphash.o dec_and_lock.o \ |
| nmi_backtrace.o win_minmax.o memcat_p.o \ |
| - buildid.o objpool.o union_find.o |
| + buildid.o objpool.o |
| |
| +lib-$(CONFIG_UNION_FIND) += union_find.o |
| lib-$(CONFIG_PRINTK) += dump_stack.o |
| lib-$(CONFIG_SMP) += cpumask.o |
| |
| _ |
