| From: Dev Jain <dev.jain@arm.com> |
| Subject: maple tree: use goto label to simplify code |
| Date: Tue, 24 Jun 2025 13:37:48 +0530 |
| |
| Use the underflow goto label to set the status to ma_underflow and return |
| NULL, as is being done elsewhere. |
| |
| [akpm@linux-foundation.org: add newline, per Liam (and remove one, per akpm)] |
| Link: https://lkml.kernel.org/r/20250624080748.4855-1-dev.jain@arm.com |
| Signed-off-by: Dev Jain <dev.jain@arm.com> |
| Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com> |
| Reviewed-by: Wei Yang <richard.weiyang@gmail.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| lib/maple_tree.c | 7 ++----- |
| 1 file changed, 2 insertions(+), 5 deletions(-) |
| |
| --- a/lib/maple_tree.c~maple-tree-use-goto-label-to-simplify-code |
| +++ a/lib/maple_tree.c |
| @@ -4560,15 +4560,12 @@ again: |
| if (unlikely(mas_rewalk_if_dead(mas, node, save_point))) |
| goto retry; |
| |
| - |
| if (likely(entry)) |
| return entry; |
| |
| if (!empty) { |
| - if (mas->index <= min) { |
| - mas->status = ma_underflow; |
| - return NULL; |
| - } |
| + if (mas->index <= min) |
| + goto underflow; |
| |
| goto again; |
| } |
| _ |