| From: Andrew Morton <akpm@linux-foundation.org> |
| Subject: in_range(): add parentheses |
| Date: Tue Jul 11 01:51:16 PM PDT 2023 |
| |
| fs/ext4/extents.c: In function 'ext4_ext_convert_to_initialized': |
| ./include/linux/minmax.h:184:23: error: logical not is only applied to the left |
| |
| Cc: Matthew Wilcox <willy@infradead.org> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| include/linux/minmax.h | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/include/linux/minmax.h~minmax-add-in_range-macro-fix-4 |
| +++ a/include/linux/minmax.h |
| @@ -181,8 +181,8 @@ static inline bool in_range32(u32 val, u |
| * Do not blindly replace one form with the other. |
| */ |
| #define in_range(val, start, len) \ |
| - sizeof(start) <= sizeof(u32) ? in_range32(val, start, len) : \ |
| - in_range64(val, start, len) |
| + (sizeof(start) <= sizeof(u32) ? in_range32(val, start, len) : \ |
| + in_range64(val, start, len)) |
| |
| /** |
| * swap - swap values of @a and @b |
| _ |