| From: Arnd Bergmann <arnd@arndb.de> |
| Subject: mips: mark local function static if possible |
| Date: Mon, 4 Dec 2023 12:56:56 +0100 |
| |
| These two functions are global but have no extern prototypes or other |
| callers, so it's best to mark them as static, avoiding these warnings: |
| |
| arch/mips/kernel/mips-cm.c:204:13: error: no previous prototype for '__mips_cm_l2sync_phys_base' [-Werror=missing-prototypes] |
| arch/mips/mm/c-r4k.c:1827:12: error: no previous prototype for 'r4k_cache_init_pm' [-Werror=missing-prototypes] |
| |
| Link: https://lkml.kernel.org/r/20231204115710.2247097-7-arnd@kernel.org |
| Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| Cc: Stephen Rothwell <sfr@rothwell.id.au> |
| Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| arch/mips/kernel/mips-cm.c | 2 +- |
| arch/mips/mm/c-r4k.c | 2 +- |
| 2 files changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/arch/mips/kernel/mips-cm.c~mips-mark-local-function-static-if-possible |
| +++ a/arch/mips/kernel/mips-cm.c |
| @@ -201,7 +201,7 @@ phys_addr_t __mips_cm_phys_base(void) |
| phys_addr_t mips_cm_phys_base(void) |
| __attribute__((weak, alias("__mips_cm_phys_base"))); |
| |
| -phys_addr_t __mips_cm_l2sync_phys_base(void) |
| +static phys_addr_t __mips_cm_l2sync_phys_base(void) |
| { |
| u32 base_reg; |
| |
| --- a/arch/mips/mm/c-r4k.c~mips-mark-local-function-static-if-possible |
| +++ a/arch/mips/mm/c-r4k.c |
| @@ -1828,7 +1828,7 @@ static struct notifier_block r4k_cache_p |
| .notifier_call = r4k_cache_pm_notifier, |
| }; |
| |
| -int __init r4k_cache_init_pm(void) |
| +static int __init r4k_cache_init_pm(void) |
| { |
| return cpu_pm_register_notifier(&r4k_cache_pm_notifier_block); |
| } |
| _ |
