| From: Keren Sun <kerensun@google.com> |
| Subject: mm: remove the non-useful else after a break in a if statement |
| Date: Fri, 15 Nov 2024 15:57:44 -0800 |
| |
| Remove the else block since there is already a break in the statement of |
| if (iter->oom_lock), just set iter->oom_lock true after the if block ends. |
| |
| Link: https://lkml.kernel.org/r/20241115235744.1419580-4-kerensun@google.com |
| Signed-off-by: Keren Sun <kerensun@google.com> |
| Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev> |
| Cc: Johannes Weiner <hannes@cmpxchg.org> |
| Cc: Michal Hocko <mhocko@kernel.org> |
| Cc: Muchun Song <muchun.song@linux.dev> |
| Cc: Shakeel Butt <shakeel.butt@linux.dev> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| mm/memcontrol-v1.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/mm/memcontrol-v1.c~mm-remove-the-non-useful-else-after-a-break-in-a-if-statement |
| +++ a/mm/memcontrol-v1.c |
| @@ -1134,8 +1134,8 @@ static bool mem_cgroup_oom_trylock(struc |
| failed = iter; |
| mem_cgroup_iter_break(memcg, iter); |
| break; |
| - } else |
| - iter->oom_lock = true; |
| + } |
| + iter->oom_lock = true; |
| } |
| |
| if (failed) { |
| _ |
