| From: Andrew Morton <akpm@linux-foundation.org> |
| Subject: mm: revert "mm: shmem: fix data-race in shmem_getattr()" |
| Date: Fri Nov 15 04:57:24 PM PST 2024 |
| |
| Revert d949d1d14fa2 ("mm: shmem: fix data-race in shmem_getattr()") as |
| suggested by Chuck [1]. It is causing deadlocks when accessing tmpfs over |
| NFS. |
| |
| As Hugh commented, "added just to silence a syzbot sanitizer splat: added |
| where there has never been any practical problem". |
| |
| Link: https://lkml.kernel.org/r/ZzdxKF39VEmXSSyN@tissot.1015granger.net [1] |
| Fixes: d949d1d14fa2 ("mm: shmem: fix data-race in shmem_getattr()") |
| Acked-by: Hugh Dickins <hughd@google.com> |
| Cc: Chuck Lever <chuck.lever@oracle.com> |
| Cc: Jeongjun Park <aha310510@gmail.com> |
| Cc: Yu Zhao <yuzhao@google.com> |
| Cc: <stable@vger.kernel.org> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| mm/shmem.c | 2 -- |
| 1 file changed, 2 deletions(-) |
| |
| --- a/mm/shmem.c~mm-revert-mm-shmem-fix-data-race-in-shmem_getattr |
| +++ a/mm/shmem.c |
| @@ -1166,9 +1166,7 @@ static int shmem_getattr(struct mnt_idma |
| stat->attributes_mask |= (STATX_ATTR_APPEND | |
| STATX_ATTR_IMMUTABLE | |
| STATX_ATTR_NODUMP); |
| - inode_lock_shared(inode); |
| generic_fillattr(idmap, request_mask, inode, stat); |
| - inode_unlock_shared(inode); |
| |
| if (shmem_huge_global_enabled(inode, 0, 0, false, NULL, 0)) |
| stat->blksize = HPAGE_PMD_SIZE; |
| _ |
