| From: Ryusuke Konishi <konishi.ryusuke@gmail.com> |
| Subject: nilfs2: fix inconsistencies in kernel-doc comments in segment.h |
| Date: Fri, 16 Aug 2024 16:43:18 +0900 |
| |
| Fix incorrect or missing variable names in the member variable |
| descriptions in the nilfs_recovery_info and nilfs_sc_info structures, |
| thereby eliminating the following warnings output by the kernel-doc |
| script: |
| |
| fs/nilfs2/segment.h:49: warning: Function parameter or struct member |
| 'ri_cno' not described in 'nilfs_recovery_info' |
| fs/nilfs2/segment.h:49: warning: Function parameter or struct member |
| 'ri_lsegs_start_seq' not described in 'nilfs_recovery_info' |
| fs/nilfs2/segment.h:49: warning: Excess struct member 'ri_ri_cno' |
| description in 'nilfs_recovery_info' |
| fs/nilfs2/segment.h:49: warning: Excess struct member 'ri_lseg_start_seq' |
| description in 'nilfs_recovery_info' |
| fs/nilfs2/segment.h:177: warning: Function parameter or struct member |
| 'sc_seq_accepted' not described in 'nilfs_sc_info' |
| fs/nilfs2/segment.h:177: warning: Function parameter or struct member |
| 'sc_timer_task' not described in 'nilfs_sc_info' |
| fs/nilfs2/segment.h:177: warning: Excess struct member 'sc_seq_accept' |
| description in 'nilfs_sc_info' |
| |
| Link: https://lkml.kernel.org/r/20240816074319.3253-8-konishi.ryusuke@gmail.com |
| Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| fs/nilfs2/segment.h | 7 ++++--- |
| 1 file changed, 4 insertions(+), 3 deletions(-) |
| |
| --- a/fs/nilfs2/segment.h~nilfs2-fix-inconsistencies-in-kernel-doc-comments-in-segmenth |
| +++ a/fs/nilfs2/segment.h |
| @@ -22,10 +22,10 @@ struct nilfs_root; |
| * struct nilfs_recovery_info - Recovery information |
| * @ri_need_recovery: Recovery status |
| * @ri_super_root: Block number of the last super root |
| - * @ri_ri_cno: Number of the last checkpoint |
| + * @ri_cno: Number of the last checkpoint |
| * @ri_lsegs_start: Region for roll-forwarding (start block number) |
| * @ri_lsegs_end: Region for roll-forwarding (end block number) |
| - * @ri_lseg_start_seq: Sequence value of the segment at ri_lsegs_start |
| + * @ri_lsegs_start_seq: Sequence value of the segment at ri_lsegs_start |
| * @ri_used_segments: List of segments to be mark active |
| * @ri_pseg_start: Block number of the last partial segment |
| * @ri_seq: Sequence number on the last partial segment |
| @@ -107,7 +107,7 @@ struct nilfs_segsum_pointer { |
| * @sc_wait_daemon: Daemon wait queue |
| * @sc_wait_task: Start/end wait queue to control segctord task |
| * @sc_seq_request: Request counter |
| - * @sc_seq_accept: Accepted request count |
| + * @sc_seq_accepted: Accepted request count |
| * @sc_seq_done: Completion counter |
| * @sc_sync: Request of explicit sync operation |
| * @sc_interval: Timeout value of background construction |
| @@ -115,6 +115,7 @@ struct nilfs_segsum_pointer { |
| * @sc_lseg_stime: Start time of the latest logical segment |
| * @sc_watermark: Watermark for the number of dirty buffers |
| * @sc_timer: Timer for segctord |
| + * @sc_timer_task: Thread woken up by @sc_timer |
| * @sc_task: current thread of segctord |
| */ |
| struct nilfs_sc_info { |
| _ |