| From: Colin Ian King <colin.i.king@gmail.com> |
| Subject: ocfs2: remove redundant assignment to variable free_space |
| |
| Variable free_space is being initialized with a value that is not read, it |
| is being re-assigned later in the two paths of an if statement. The early |
| initialization is redundant and can be removed. |
| |
| Link: https://lkml.kernel.org/r/20220112230411.1090761-1-colin.i.king@gmail.com |
| Signed-off-by: Colin Ian King <colin.i.king@gmail.com> |
| Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com> |
| Cc: Mark Fasheh <mark@fasheh.com> |
| Cc: Joel Becker <jlbec@evilplan.org> |
| Cc: Junxiao Bi <junxiao.bi@oracle.com> |
| Cc: Changwei Ge <gechangwei@live.cn> |
| Cc: Gang He <ghe@suse.com> |
| Cc: Jun Piao <piaojun@huawei.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| fs/ocfs2/dir.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/ocfs2/dir.c~ocfs2-remove-redundant-assignment-to-variable-free_space |
| +++ a/fs/ocfs2/dir.c |
| @@ -3343,7 +3343,7 @@ static int ocfs2_find_dir_space_id(struc |
| struct ocfs2_dir_entry *de, *last_de = NULL; |
| char *de_buf, *limit; |
| unsigned long offset = 0; |
| - unsigned int rec_len, new_rec_len, free_space = dir->i_sb->s_blocksize; |
| + unsigned int rec_len, new_rec_len, free_space; |
| |
| /* |
| * This calculates how many free bytes we'd have in block zero, should |
| _ |
