| From: Lizhi Xu <lizhi.xu@windriver.com> |
| Subject: ocfs2: remove unreasonable unlock |
| Date: Tue, 20 Aug 2024 17:45:11 +0800 |
| |
| There was a lock release before exiting, so remove the unreasonable |
| unlock. |
| |
| Link: https://lkml.kernel.org/r/20240820094512.2228159-1-lizhi.xu@windriver.com |
| Signed-off-by: Lizhi Xu <lizhi.xu@windriver.com> |
| Reported-by: syzbot+ab134185af9ef88dfed5@syzkaller.appspotmail.com |
| Closes: https://syzkaller.appspot.com/bug?extid=ab134185af9ef88dfed5 |
| Tested-by: syzbot+ab134185af9ef88dfed5@syzkaller.appspotmail.com |
| Reviewed-by: Heming Zhao <heming.zhao@suse.com> |
| Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com> |
| Cc: Joel Becker <jlbec@evilplan.org> |
| Cc: Mark Fasheh <mark@fasheh.com> |
| Cc: Junxiao Bi <junxiao.bi@oracle.com> |
| Cc: Changwei Ge <gechangwei@live.cn> |
| Cc: Gang He <ghe@suse.com> |
| Cc: Jun Piao <piaojun@huawei.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| fs/ocfs2/buffer_head_io.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| --- a/fs/ocfs2/buffer_head_io.c~ocfs2-remove-unreasonable-unlock |
| +++ a/fs/ocfs2/buffer_head_io.c |
| @@ -235,7 +235,6 @@ int ocfs2_read_blocks(struct ocfs2_cachi |
| if (bhs[i] == NULL) { |
| bhs[i] = sb_getblk(sb, block++); |
| if (bhs[i] == NULL) { |
| - ocfs2_metadata_cache_io_unlock(ci); |
| status = -ENOMEM; |
| mlog_errno(status); |
| /* Don't forget to put previous bh! */ |
| _ |
