| From: Petr Mladek <pmladek@suse.com> |
| Subject: panic: clean up message about deprecated 'panic_print' parameter |
| Date: Mon, 25 Aug 2025 10:57:01 +0800 |
| |
| Remove duplication of the message about deprecated 'panic_print' |
| parameter. |
| |
| Also make the wording more direct. Make it clear that the new parameters |
| already exist and should be used instead. |
| |
| Link: https://lkml.kernel.org/r/20250825025701.81921-5-feng.tang@linux.alibaba.com |
| Signed-off-by: Petr Mladek <pmladek@suse.com> |
| Signed-off-by: Feng Tang <feng.tang@linux.alibaba.com> |
| Reviewed-by: Lance Yang <lance.yang@linux.dev> |
| Tested-by: Lance Yang <lance.yang@linux.dev> |
| Reviewed-by: Feng Tang <feng.tang@linux.alibaba.com> |
| Cc: Askar Safin <safinaskar@zohomail.com> |
| Cc: John Ogness <john.ogness@linutronix.de> |
| Cc: Jonathan Corbet <corbet@lwn.net> |
| Cc: "Paul E . McKenney" <paulmck@kernel.org> |
| Cc: Steven Rostedt <rostedt@goodmis.org> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| kernel/panic.c | 11 ++++++++--- |
| 1 file changed, 8 insertions(+), 3 deletions(-) |
| |
| --- a/kernel/panic.c~panic-clean-up-message-about-deprecated-panic_print-parameter |
| +++ a/kernel/panic.c |
| @@ -77,6 +77,11 @@ ATOMIC_NOTIFIER_HEAD(panic_notifier_list |
| |
| EXPORT_SYMBOL(panic_notifier_list); |
| |
| +static void panic_print_deprecated(void) |
| +{ |
| + pr_info_once("Kernel: The 'panic_print' parameter is now deprecated. Please use 'panic_sys_info' and 'panic_console_replay' instead.\n"); |
| +} |
| + |
| #ifdef CONFIG_SYSCTL |
| |
| /* |
| @@ -125,7 +130,7 @@ static int proc_taint(const struct ctl_t |
| static int sysctl_panic_print_handler(const struct ctl_table *table, int write, |
| void *buffer, size_t *lenp, loff_t *ppos) |
| { |
| - pr_info_once("Kernel: 'panic_print' sysctl interface will be obsoleted by both 'panic_sys_info' and 'panic_console_replay'\n"); |
| + panic_print_deprecated(); |
| return proc_doulongvec_minmax(table, write, buffer, lenp, ppos); |
| } |
| |
| @@ -944,13 +949,13 @@ core_param(panic_console_replay, panic_c |
| |
| static int panic_print_set(const char *val, const struct kernel_param *kp) |
| { |
| - pr_info_once("Kernel: 'panic_print' parameter will be obsoleted by both 'panic_sys_info' and 'panic_console_replay'\n"); |
| + panic_print_deprecated(); |
| return param_set_ulong(val, kp); |
| } |
| |
| static int panic_print_get(char *val, const struct kernel_param *kp) |
| { |
| - pr_info_once("Kernel: 'panic_print' parameter will be obsoleted by both 'panic_sys_info' and 'panic_console_replay'\n"); |
| + panic_print_deprecated(); |
| return param_get_ulong(val, kp); |
| } |
| |
| _ |