| From: Rong Tao <rongtao@cestc.cn> |
| Subject: lib/radix-tree.c: fix uninitialized variable compilation warning |
| Date: Wed, 9 Nov 2022 22:34:25 +0800 |
| |
| We need to set an initial value for offset to eliminate compilation |
| warning. |
| |
| How to reproduce warning: |
| |
| $ make -C tools/testing/radix-tree |
| radix-tree.c: In function `radix_tree_tag_clear': |
| radix-tree.c:1046:17: warning: `offset' may be used uninitialized in this function [-Wmaybe-uninitialized] |
| 1046 | node_tag_clear(root, parent, tag, offset); |
| | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
| |
| Link: https://lkml.kernel.org/r/tencent_DF74099967595DCEA93CBDC28D062026180A@qq.com |
| Signed-off-by: Rong Tao <rongtao@cestc.cn> |
| Cc: Matthew Wilcox <willy@infradead.org> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| lib/radix-tree.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/lib/radix-tree.c~radix-tree-test-suite-fix-uninitialized-variable-compilation-warning |
| +++ a/lib/radix-tree.c |
| @@ -1029,7 +1029,7 @@ void *radix_tree_tag_clear(struct radix_ |
| { |
| struct radix_tree_node *node, *parent; |
| unsigned long maxindex; |
| - int offset; |
| + int offset = 0; |
| |
| radix_tree_load_root(root, &node, &maxindex); |
| if (index > maxindex) |
| _ |