| From: Andrew Morton <akpm@linux-foundation.org> |
| Subject: revert "memfd: improve userspace warnings for missing exec-related flags". |
| Date: Sat Sep 2 03:59:31 PM PDT 2023 |
| |
| This warning is telling userspace developers to pass MFD_EXEC and |
| MFD_NOEXEC_SEAL to memfd_create(). Commit 434ed3350f57 ("memfd: improve |
| userspace warnings for missing exec-related flags") made the warning more |
| frequent and visible in the hope that this would accelerate the fixing of |
| errant userspace. |
| |
| But the overall effect is to generate far too much dmesg noise. |
| |
| Fixes: 434ed3350f57 ("memfd: improve userspace warnings for missing exec-related flags") |
| Reported-by: Damian Tometzki <dtometzki@fedoraproject.org> |
| Closes: https://lkml.kernel.org/r/ZPFzCSIgZ4QuHsSC@fedora.fritz.box |
| Cc: Aleksa Sarai <cyphar@cyphar.com> |
| Cc: Christian Brauner <brauner@kernel.org> |
| Cc: Daniel Verkamp <dverkamp@chromium.org> |
| Cc: Jeff Xu <jeffxu@google.com> |
| Cc: Kees Cook <keescook@chromium.org> |
| Cc: Shuah Khan <shuah@kernel.org> |
| Cc: <stable@vger.kernel.org> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| mm/memfd.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/mm/memfd.c~revert-memfd-improve-userspace-warnings-for-missing-exec-related-flags |
| +++ a/mm/memfd.c |
| @@ -316,7 +316,7 @@ SYSCALL_DEFINE2(memfd_create, |
| return -EINVAL; |
| |
| if (!(flags & (MFD_EXEC | MFD_NOEXEC_SEAL))) { |
| - pr_info_ratelimited( |
| + pr_warn_once( |
| "%s[%d]: memfd_create() called without MFD_EXEC or MFD_NOEXEC_SEAL set\n", |
| current->comm, task_pid_nr(current)); |
| } |
| _ |
