| From: Florian Fainelli <f.fainelli@gmail.com> |
| Subject: scripts/gdb: bail early if there are no generic PD |
| Date: Thu, 23 Mar 2023 16:16:57 -0700 |
| |
| Avoid generating an exception if there are no generic power domain(s) |
| registered: |
| |
| (gdb) lx-genpd-summary |
| domain status children |
| /device runtime status |
| ---------------------------------------------------------------------- |
| Python Exception <class 'gdb.error'>: No symbol "gpd_list" in current context. |
| Error occurred in Python: No symbol "gpd_list" in current context. |
| (gdb) quit |
| |
| [f.fainelli@gmail.com: correctly invoke gdb_eval_or_none] |
| Link: https://lkml.kernel.org/r/20230327185746.3856407-1-f.fainelli@gmail.com |
| Link: https://lkml.kernel.org/r/20230323231659.3319941-1-f.fainelli@gmail.com |
| Fixes: 8207d4a88e1e ("scripts/gdb: add lx-genpd-summary command") |
| Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> |
| Cc: Jan Kiszka <jan.kiszka@siemens.com> |
| Cc: Kieran Bingham <kbingham@kernel.org> |
| Cc: Leonard Crestez <leonard.crestez@nxp.com> |
| Cc: Stephen Boyd <sboyd@kernel.org> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| scripts/gdb/linux/genpd.py | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| --- a/scripts/gdb/linux/genpd.py~scripts-gdb-bail-early-if-there-are-no-generic-pd |
| +++ a/scripts/gdb/linux/genpd.py |
| @@ -5,7 +5,7 @@ |
| import gdb |
| import sys |
| |
| -from linux.utils import CachedType |
| +from linux.utils import CachedType, gdb_eval_or_none |
| from linux.lists import list_for_each_entry |
| |
| generic_pm_domain_type = CachedType('struct generic_pm_domain') |
| @@ -70,6 +70,8 @@ Output is similar to /sys/kernel/debug/p |
| gdb.write(' %-50s %s\n' % (kobj_path, rtpm_status_str(dev))) |
| |
| def invoke(self, arg, from_tty): |
| + if gdb_eval_or_none("&gpd_list") is None: |
| + raise gdb.GdbError("No power domain(s) registered") |
| gdb.write('domain status children\n'); |
| gdb.write(' /device runtime status\n'); |
| gdb.write('----------------------------------------------------------------------\n'); |
| _ |
