| From: Enze Li <lienze@kylinos.cn> |
| Subject: selftests/damon: remove the remaining test scripts for DAMON debugfs interface |
| Date: Fri, 11 Apr 2025 10:43:32 +0800 |
| |
| DAMON has dropped debugfs support; therefore, remove these unused scripts. |
| |
| Link: https://lkml.kernel.org/r/20250411024332.1373861-1-enze.li@linux.dev |
| Fixes: 5ec4333b1967 ("mm/damon: remove DAMON debugfs interface") |
| Signed-off-by: Enze Li <lienze@kylinos.cn> |
| Reviewed-by: SeongJae Park <sj@kernel.org> |
| Cc: Shuah Khan <shuah@kernel.org> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| tools/testing/selftests/damon/Makefile | 2 |
| tools/testing/selftests/damon/_chk_dependency.sh | 52 ---------- |
| tools/testing/selftests/damon/_debugfs_common.sh | 64 ------------- |
| 3 files changed, 1 insertion(+), 117 deletions(-) |
| |
| diff --git a/tools/testing/selftests/damon/_chk_dependency.sh a/tools/testing/selftests/damon/_chk_dependency.sh |
| deleted file mode 100644 |
| --- a/tools/testing/selftests/damon/_chk_dependency.sh |
| +++ /dev/null |
| @@ -1,52 +0,0 @@ |
| -#!/bin/bash |
| -# SPDX-License-Identifier: GPL-2.0 |
| - |
| -# Kselftest framework requirement - SKIP code is 4. |
| -ksft_skip=4 |
| - |
| -DBGFS=$(grep debugfs /proc/mounts --max-count 1 | awk '{print $2}') |
| -if [ "$DBGFS" = "" ] |
| -then |
| - echo "debugfs not mounted" |
| - exit $ksft_skip |
| -fi |
| - |
| -DBGFS+="/damon" |
| - |
| -if [ $EUID -ne 0 ]; |
| -then |
| - echo "Run as root" |
| - exit $ksft_skip |
| -fi |
| - |
| -if [ ! -d "$DBGFS" ] |
| -then |
| - echo "$DBGFS not found" |
| - exit $ksft_skip |
| -fi |
| - |
| -if [ -f "$DBGFS/monitor_on_DEPRECATED" ] |
| -then |
| - monitor_on_file="monitor_on_DEPRECATED" |
| -else |
| - monitor_on_file="monitor_on" |
| -fi |
| - |
| -for f in attrs target_ids "$monitor_on_file" |
| -do |
| - if [ ! -f "$DBGFS/$f" ] |
| - then |
| - echo "$f not found" |
| - exit 1 |
| - fi |
| -done |
| - |
| -permission_error="Operation not permitted" |
| -for f in attrs target_ids "$monitor_on_file" |
| -do |
| - status=$( cat "$DBGFS/$f" 2>&1 ) |
| - if [ "${status#*$permission_error}" != "$status" ]; then |
| - echo "Permission for reading $DBGFS/$f denied; maybe secureboot enabled?" |
| - exit $ksft_skip |
| - fi |
| -done |
| diff --git a/tools/testing/selftests/damon/_debugfs_common.sh a/tools/testing/selftests/damon/_debugfs_common.sh |
| deleted file mode 100644 |
| --- a/tools/testing/selftests/damon/_debugfs_common.sh |
| +++ /dev/null |
| @@ -1,64 +0,0 @@ |
| -#!/bin/bash |
| -# SPDX-License-Identifier: GPL-2.0 |
| - |
| -test_write_result() { |
| - file=$1 |
| - content=$2 |
| - orig_content=$3 |
| - expect_reason=$4 |
| - expected=$5 |
| - |
| - if [ "$expected" = "0" ] |
| - then |
| - echo "$content" > "$file" |
| - else |
| - echo "$content" > "$file" 2> /dev/null |
| - fi |
| - if [ $? -ne "$expected" ] |
| - then |
| - echo "writing $content to $file doesn't return $expected" |
| - echo "expected because: $expect_reason" |
| - echo "$orig_content" > "$file" |
| - exit 1 |
| - fi |
| -} |
| - |
| -test_write_succ() { |
| - test_write_result "$1" "$2" "$3" "$4" 0 |
| -} |
| - |
| -test_write_fail() { |
| - test_write_result "$1" "$2" "$3" "$4" 1 |
| -} |
| - |
| -test_content() { |
| - file=$1 |
| - orig_content=$2 |
| - expected=$3 |
| - expect_reason=$4 |
| - |
| - content=$(cat "$file") |
| - if [ "$content" != "$expected" ] |
| - then |
| - echo "reading $file expected $expected but $content" |
| - echo "expected because: $expect_reason" |
| - echo "$orig_content" > "$file" |
| - exit 1 |
| - fi |
| -} |
| - |
| -source ./_chk_dependency.sh |
| - |
| -damon_onoff="$DBGFS/monitor_on" |
| -if [ -f "$DBGFS/monitor_on_DEPRECATED" ] |
| -then |
| - damon_onoff="$DBGFS/monitor_on_DEPRECATED" |
| -else |
| - damon_onoff="$DBGFS/monitor_on" |
| -fi |
| - |
| -if [ $(cat "$damon_onoff") = "on" ] |
| -then |
| - echo "monitoring is on" |
| - exit $ksft_skip |
| -fi |
| --- a/tools/testing/selftests/damon/Makefile~selftests-damon-remove-the-remaining-test-scripts-for-damon-debugfs-interface |
| +++ a/tools/testing/selftests/damon/Makefile |
| @@ -3,7 +3,7 @@ |
| |
| TEST_GEN_FILES += access_memory access_memory_even |
| |
| -TEST_FILES = _chk_dependency.sh _damon_sysfs.py |
| +TEST_FILES = _damon_sysfs.py |
| |
| # functionality tests |
| TEST_PROGS += sysfs.sh |
| _ |