| From: Edward Liaw <edliaw@google.com> |
| Subject: selftests/kcmp: remove unused open mode |
| Date: Mon, 29 Apr 2024 23:46:09 +0000 |
| |
| Android bionic warns that open modes are ignored if O_CREAT or O_TMPFILE |
| aren't specified. The permissions for the file are set above: |
| |
| fd1 = open(kpath, O_RDWR | O_CREAT | O_TRUNC, 0644); |
| |
| Link: https://lkml.kernel.org/r/20240429234610.191144-1-edliaw@google.com |
| Fixes: d97b46a64674 ("syscalls, x86: add __NR_kcmp syscall") |
| Signed-off-by: Edward Liaw <edliaw@google.com> |
| Reviewed-by: Cyrill Gorcunov <gorcunov@gmail.com> |
| Cc: Eric Biederman <ebiederm@xmission.com> |
| Cc: Shuah Khan <shuah@kernel.org> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| tools/testing/selftests/kcmp/kcmp_test.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/tools/testing/selftests/kcmp/kcmp_test.c~selftests-kcmp-remove-unused-open-mode |
| +++ a/tools/testing/selftests/kcmp/kcmp_test.c |
| @@ -91,7 +91,7 @@ int main(int argc, char **argv) |
| ksft_print_header(); |
| ksft_set_plan(3); |
| |
| - fd2 = open(kpath, O_RDWR, 0644); |
| + fd2 = open(kpath, O_RDWR); |
| if (fd2 < 0) { |
| perror("Can't open file"); |
| ksft_exit_fail(); |
| _ |
