| From: Andrew Morton <akpm@linux-foundation.org> |
| Subject: squashfs-implement-readahead-checkpatch-fixes |
| Date: Wed Jun 1 01:59:05 PM PDT 2022 |
| |
| ERROR: need consistent spacing around '&' (ctx:WxO) |
| #54: FILE: fs/squashfs/file.c:505: |
| + loff_t start = readahead_pos(ractl) &~ mask; |
| ^ |
| |
| ERROR: space prohibited after that '~' (ctx:OxW) |
| #54: FILE: fs/squashfs/file.c:505: |
| + loff_t start = readahead_pos(ractl) &~ mask; |
| ^ |
| |
| total: 2 errors, 0 warnings, 109 lines checked |
| |
| NOTE: For some of the reported defects, checkpatch may be able to |
| mechanically convert to the typical style using --fix or --fix-inplace. |
| |
| ./patches/squashfs-implement-readahead.patch has style problems, please review. |
| |
| NOTE: If any of the errors are false positives, please report |
| them to the maintainer, see CHECKPATCH in MAINTAINERS. |
| |
| Please run checkpatch prior to sending patches |
| |
| Cc: Hsin-Yi Wang <hsinyi@chromium.org> |
| Cc: Phillip Lougher <phillip@squashfs.org.uk> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| fs/squashfs/file.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/squashfs/file.c~squashfs-implement-readahead-checkpatch-fixes |
| +++ a/fs/squashfs/file.c |
| @@ -502,7 +502,7 @@ static void squashfs_readahead(struct re |
| struct squashfs_sb_info *msblk = inode->i_sb->s_fs_info; |
| size_t mask = (1UL << msblk->block_log) - 1; |
| unsigned short shift = msblk->block_log - PAGE_SHIFT; |
| - loff_t start = readahead_pos(ractl) &~ mask; |
| + loff_t start = readahead_pos(ractl) & ~mask; |
| size_t len = readahead_length(ractl) + readahead_pos(ractl) - start; |
| struct squashfs_page_actor *actor; |
| unsigned int nr_pages = 0; |
| _ |
