| From: Liao Yuanhong <liaoyuanhong@vivo.com> |
| Subject: x86/crash: remove redundant 0 value initialization |
| Date: Mon, 18 Aug 2025 20:35:28 +0800 |
| |
| The crash_mem struct is already zeroed by vzalloc(). It's redundant to |
| initialize cmem->nr_ranges to 0. |
| |
| Link: https://lkml.kernel.org/r/20250818123530.635234-1-liaoyuanhong@vivo.com |
| Signed-off-by: Liao Yuanhong <liaoyuanhong@vivo.com> |
| Cc: Baoquan He <bhe@redhat.com> |
| Cc: Borislav Betkov <bp@alien8.de> |
| Cc: Brian Gerst <brgerst@gmail.com> |
| Cc: Coiby Xu <coxu@redhat.com> |
| Cc: "H. Peter Anvin" <hpa@zytor.com> |
| Cc: Ingo Molnar <mingo@redhat.com> |
| Cc: Jiri Bohac <jbohac@suse.cz> |
| Cc: Thomas Gleinxer <tglx@linutronix.de> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| arch/x86/kernel/crash.c | 2 -- |
| 1 file changed, 2 deletions(-) |
| |
| --- a/arch/x86/kernel/crash.c~x86-crash-remove-redundant-0-value-initialization |
| +++ a/arch/x86/kernel/crash.c |
| @@ -172,7 +172,6 @@ static struct crash_mem *fill_up_crash_e |
| return NULL; |
| |
| cmem->max_nr_ranges = nr_ranges; |
| - cmem->nr_ranges = 0; |
| |
| return cmem; |
| } |
| @@ -332,7 +331,6 @@ int crash_setup_memmap_entries(struct ki |
| return -ENOMEM; |
| |
| cmem->max_nr_ranges = nr_ranges; |
| - cmem->nr_ranges = 0; |
| |
| memset(&cmd, 0, sizeof(struct crash_memmap_data)); |
| cmd.params = params; |
| _ |
