| From: Sergey Senozhatsky <senozhatsky@chromium.org> |
| Subject: zram: modernize writeback interface |
| Date: Fri, 4 Apr 2025 10:52:50 +0900 |
| |
| simplify parse_page_index() range checks, per Brian |
| |
| Link: https://lkml.kernel.org/r/20250404015327.2427684-1-senozhatsky@chromium.org |
| Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org> |
| Reviewed-by: Brian Geffon <bgeffon@google.com> |
| Cc: Brian Geffon <bgeffon@google.com> |
| Cc: Minchan Kim <minchan@kernel.org> |
| Cc: Richard Chang <richardycc@google.com> |
| Cc: Dan Carpenter <dan.carpenter@linaro.org> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| --- |
| |
| drivers/block/zram/zram_drv.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/block/zram/zram_drv.c~zram-modernize-writeback-interface-v3 |
| +++ a/drivers/block/zram/zram_drv.c |
| @@ -853,9 +853,9 @@ static int parse_page_index(char *val, u |
| ret = kstrtoul(val, 10, lo); |
| if (ret) |
| return ret; |
| - *hi = *lo + 1; |
| - if (*lo >= nr_pages || *hi > nr_pages) |
| + if (*lo >= nr_pages) |
| return -ERANGE; |
| + *hi = *lo + 1; |
| return 0; |
| } |
| |
| _ |