commit 4316f6409721bc42e878df1057de0e4be7df3d44
author Alexey Dobriyan <adobriyan@gmail.com> Mon Feb 22 16:21:22 2021 +0300
committer Jens Axboe <axboe@kernel.dk> Mon Feb 22 07:35:34 2021 -0700
tree 0b4d37404a77752f75acb5e14a3f8382de9941b0
parent b75c0fae66129883dc554fecb6eaa4b35938c14e

zbd: simplify zoneskip= validness check

Simply check the remainder:

	(zoneskip % zone_size) > 0

It will do the right thing for all zoneskip= values, and
zone size being positive is checked earlier.

Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: Alexey Dobriyan (SK hynix) <adobriyan@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

zbd.c

diff --git a/zbd.c b/zbd.c
index 6a26fe1..a93a977 100644
--- a/zbd.c
+++ b/zbd.c
@@ -285,9 +285,7 @@
 				return false;
 			}
 
-			if (td->o.zone_skip &&
-			    (td->o.zone_skip < td->o.zone_size ||
-			     td->o.zone_skip % td->o.zone_size)) {
+			if (td->o.zone_skip % td->o.zone_size) {
 				log_err("%s: zoneskip %llu is not a multiple of the device zone size %llu.\n",
 					f->file_name, (unsigned long long) td->o.zone_skip,
 					(unsigned long long) td->o.zone_size);