| From: Guenter Roeck <linux@roeck-us.net> |
| Date: Sun, 20 Nov 2016 10:37:39 -0800 |
| Subject: hwmon: (ds620) Fix overflows seen when writing temperature limits |
| |
| commit e36ce99ee0815d7919a7b589bfb66f3de50b6bc7 upstream. |
| |
| Module test reports: |
| |
| temp1_max: Suspected overflow: [160000 vs. 0] |
| temp1_min: Suspected overflow: [160000 vs. 0] |
| |
| This is seen because the values passed when writing temperature limits |
| are unbound. |
| |
| Reviewed-by: Jean Delvare <jdelvare@suse.de> |
| Fixes: 6099469805c2 ("hwmon: Support for Dallas Semiconductor DS620") |
| Signed-off-by: Guenter Roeck <linux@roeck-us.net> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| drivers/hwmon/ds620.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/hwmon/ds620.c |
| +++ b/drivers/hwmon/ds620.c |
| @@ -166,7 +166,7 @@ static ssize_t set_temp(struct device *d |
| if (res) |
| return res; |
| |
| - val = (val * 10 / 625) * 8; |
| + val = (clamp_val(val, -128000, 128000) * 10 / 625) * 8; |
| |
| mutex_lock(&data->update_lock); |
| data->temp[attr->index] = val; |
