| From: Sean Christopherson <sean.j.christopherson@intel.com> |
| Date: Wed, 18 Dec 2019 13:54:48 -0800 |
| Subject: KVM: x86: Free wbinvd_dirty_mask if vCPU creation fails |
| |
| commit 16be9ddea268ad841457a59109963fff8c9de38d upstream. |
| |
| Free the vCPU's wbinvd_dirty_mask if vCPU creation fails after |
| kvm_arch_vcpu_init(), e.g. when installing the vCPU's file descriptor. |
| Do the freeing by calling kvm_arch_vcpu_free() instead of open coding |
| the freeing. This adds a likely superfluous, but ultimately harmless, |
| call to kvmclock_reset(), which only clears vcpu->arch.pv_time_enabled. |
| Using kvm_arch_vcpu_free() allows for additional cleanup in the future. |
| |
| Fixes: f5f48ee15c2ee ("KVM: VMX: Execute WBINVD to keep data consistency with assigned devices") |
| Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> |
| Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> |
| [bwh: Backported to 3.16: Also delete the preceding fx_free(), since |
| kvm_arch_vcpu_free() calls it.] |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| --- a/arch/x86/kvm/x86.c |
| +++ b/arch/x86/kvm/x86.c |
| @@ -7087,8 +7087,7 @@ void kvm_arch_vcpu_destroy(struct kvm_vc |
| kvm_mmu_unload(vcpu); |
| vcpu_put(vcpu); |
| |
| - fx_free(vcpu); |
| - kvm_x86_ops->vcpu_free(vcpu); |
| + kvm_arch_vcpu_free(vcpu); |
| } |
| |
| void kvm_vcpu_reset(struct kvm_vcpu *vcpu) |
