| From: Johan Hovold <johan@kernel.org> |
| Date: Tue, 10 Dec 2019 12:44:25 +0100 |
| Subject: rsi_91x_usb: fix interface sanity check |
| |
| commit 3139b180906af43bc09bd3373fc2338a8271d9d9 upstream. |
| |
| Make sure to use the current alternate setting when verifying the |
| interface descriptors to avoid binding to an invalid interface. |
| |
| Failing to do so could cause the driver to misbehave or trigger a WARN() |
| in usb_submit_urb() that kernels with panic_on_warn set would choke on. |
| |
| Fixes: dad0d04fa7ba ("rsi: Add RS9113 wireless driver") |
| Cc: Fariya Fatima <fariyaf@gmail.com> |
| Signed-off-by: Johan Hovold <johan@kernel.org> |
| Signed-off-by: Kalle Valo <kvalo@codeaurora.org> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| drivers/net/wireless/rsi/rsi_91x_usb.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/net/wireless/rsi/rsi_91x_usb.c |
| +++ b/drivers/net/wireless/rsi/rsi_91x_usb.c |
| @@ -103,7 +103,7 @@ static int rsi_find_bulk_in_and_out_endp |
| __le16 buffer_size; |
| int ii, bep_found = 0; |
| |
| - iface_desc = &(interface->altsetting[0]); |
| + iface_desc = interface->cur_altsetting; |
| |
| for (ii = 0; ii < iface_desc->desc.bNumEndpoints; ++ii) { |
| endpoint = &(iface_desc->endpoint[ii].desc); |
