| From: Colin Ian King <colin.king@canonical.com> |
| Date: Sat, 4 May 2019 17:48:29 +0100 |
| Subject: scsi: bnx2fc: fix incorrect cast to u64 on shift operation |
| |
| commit d0c0d902339249c75da85fd9257a86cbb98dfaa5 upstream. |
| |
| Currently an int is being shifted and the result is being cast to a u64 |
| which leads to undefined behaviour if the shift is more than 31 bits. Fix |
| this by casting the integer value 1 to u64 before the shift operation. |
| |
| Addresses-Coverity: ("Bad shift operation") |
| Fixes: 7b594769120b ("[SCSI] bnx2fc: Handle REC_TOV error code from firmware") |
| Signed-off-by: Colin Ian King <colin.king@canonical.com> |
| Acked-by: Saurav Kashyap <skashyap@marvell.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| drivers/scsi/bnx2fc/bnx2fc_hwi.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/scsi/bnx2fc/bnx2fc_hwi.c |
| +++ b/drivers/scsi/bnx2fc/bnx2fc_hwi.c |
| @@ -828,7 +828,7 @@ ret_err_rqe: |
| ((u64)err_entry->data.err_warn_bitmap_hi << 32) | |
| (u64)err_entry->data.err_warn_bitmap_lo; |
| for (i = 0; i < BNX2FC_NUM_ERR_BITS; i++) { |
| - if (err_warn_bit_map & (u64) (1 << i)) { |
| + if (err_warn_bit_map & ((u64)1 << i)) { |
| err_warn = i; |
| break; |
| } |
