| From: Johan Hovold <johan@kernel.org> |
| Date: Thu, 16 Mar 2017 11:37:01 -0700 |
| Subject: Input: yealink - validate number of endpoints before using them |
| |
| commit 5cc4a1a9f5c179795c8a1f2b0f4361829d6a070e upstream. |
| |
| Make sure to check the number of endpoints to avoid dereferencing a |
| NULL-pointer should a malicious device lack endpoints. |
| |
| Fixes: aca951a22a1d ("[PATCH] input-driver-yealink-P1K-usb-phone") |
| Signed-off-by: Johan Hovold <johan@kernel.org> |
| Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| drivers/input/misc/yealink.c | 4 ++++ |
| 1 file changed, 4 insertions(+) |
| |
| --- a/drivers/input/misc/yealink.c |
| +++ b/drivers/input/misc/yealink.c |
| @@ -875,6 +875,10 @@ static int usb_probe(struct usb_interfac |
| int ret, pipe, i; |
| |
| interface = intf->cur_altsetting; |
| + |
| + if (interface->desc.bNumEndpoints < 1) |
| + return -ENODEV; |
| + |
| endpoint = &interface->endpoint[0].desc; |
| if (!usb_endpoint_is_int_in(endpoint)) |
| return -ENODEV; |