| From: Vinicius Costa Gomes <vinicius.gomes@intel.com> |
| Date: Wed, 14 Mar 2018 13:32:09 -0700 |
| Subject: skbuff: Fix not waking applications when errors are enqueued |
| |
| commit 6e5d58fdc9bedd0255a8781b258f10bbdc63e975 upstream. |
| |
| When errors are enqueued to the error queue via sock_queue_err_skb() |
| function, it is possible that the waiting application is not notified. |
| |
| Calling 'sk->sk_data_ready()' would not notify applications that |
| selected only POLLERR events in poll() (for example). |
| |
| Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") |
| Reported-by: Randy E. Witt <randy.e.witt@intel.com> |
| Reviewed-by: Eric Dumazet <edumazet@google.com> |
| Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| net/core/skbuff.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/net/core/skbuff.c |
| +++ b/net/core/skbuff.c |
| @@ -3512,7 +3512,7 @@ int sock_queue_err_skb(struct sock *sk, |
| |
| skb_queue_tail(&sk->sk_error_queue, skb); |
| if (!sock_flag(sk, SOCK_DEAD)) |
| - sk->sk_data_ready(sk); |
| + sk->sk_error_report(sk); |
| return 0; |
| } |
| EXPORT_SYMBOL(sock_queue_err_skb); |
