| From: Lukas Czerner <lczerner@redhat.com> |
| Date: Tue, 2 Oct 2018 21:18:45 -0400 |
| Subject: ext4: initialize retries variable in |
| ext4_da_write_inline_data_begin() |
| |
| commit 625ef8a3acd111d5f496d190baf99d1a815bd03e upstream. |
| |
| Variable retries is not initialized in ext4_da_write_inline_data_begin() |
| which can lead to nondeterministic number of retries in case we hit |
| ENOSPC. Initialize retries to zero as we do everywhere else. |
| |
| Signed-off-by: Lukas Czerner <lczerner@redhat.com> |
| Signed-off-by: Theodore Ts'o <tytso@mit.edu> |
| Fixes: bc0ca9df3b2a ("ext4: retry allocation when inline->extent conversion failed") |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| fs/ext4/inline.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/ext4/inline.c |
| +++ b/fs/ext4/inline.c |
| @@ -859,7 +859,7 @@ int ext4_da_write_inline_data_begin(stru |
| handle_t *handle; |
| struct page *page; |
| struct ext4_iloc iloc; |
| - int retries; |
| + int retries = 0; |
| |
| ret = ext4_get_inode_loc(inode, &iloc); |
| if (ret) |
