| From: Prarit Bhargava <prarit@redhat.com> |
| Date: Thu, 17 Oct 2013 08:00:11 -0400 |
| Subject: powerpc/vio: use strcpy in modalias_show |
| |
| commit 411cabf79e684171669ad29a0628c400b4431e95 upstream. |
| |
| Commit e82b89a6f19bae73fb064d1b3dd91fcefbb478f4 used strcat instead of |
| strcpy which can result in an overflow of newlines on the buffer. |
| |
| Signed-off-by: Prarit Bhargava |
| Cc: benh@kernel.crashing.org |
| Cc: ben@decadent.org.uk |
| Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| arch/powerpc/kernel/vio.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/arch/powerpc/kernel/vio.c |
| +++ b/arch/powerpc/kernel/vio.c |
| @@ -1352,12 +1352,12 @@ static ssize_t modalias_show(struct devi |
| |
| dn = dev->of_node; |
| if (!dn) { |
| - strcat(buf, "\n"); |
| + strcpy(buf, "\n"); |
| return strlen(buf); |
| } |
| cp = of_get_property(dn, "compatible", NULL); |
| if (!cp) { |
| - strcat(buf, "\n"); |
| + strcpy(buf, "\n"); |
| return strlen(buf); |
| } |
| |
