| From: Matthew Thode <mthode@mthode.org> |
| Date: Tue, 17 Feb 2015 18:31:57 -0600 |
| Subject: net: reject creation of netdev names with colons |
| |
| [ Upstream commit a4176a9391868bfa87705bcd2e3b49e9b9dd2996 ] |
| |
| colons are used as a separator in netdev device lookup in dev_ioctl.c |
| |
| Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME |
| |
| Signed-off-by: Matthew Thode <mthode@mthode.org> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| [bwh: Backported to 3.2: adjust context] |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| net/core/dev.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/net/core/dev.c |
| +++ b/net/core/dev.c |
| @@ -859,7 +859,7 @@ int dev_valid_name(const char *name) |
| return 0; |
| |
| while (*name) { |
| - if (*name == '/' || isspace(*name)) |
| + if (*name == '/' || *name == ':' || isspace(*name)) |
| return 0; |
| name++; |
| } |
