| From: Johan Hovold <johan@kernel.org> |
| Date: Mon, 13 Mar 2017 13:47:52 +0100 |
| Subject: uwb: hwa-rc: fix NULL-deref at probe |
| |
| commit daf229b15907fbfdb6ee183aac8ca428cb57e361 upstream. |
| |
| Make sure to check the number of endpoints to avoid dereferencing a |
| NULL-pointer should a malicious device lack endpoints. |
| |
| Note that the dereference happens in the start callback which is called |
| during probe. |
| |
| Fixes: de520b8bd552 ("uwb: add HWA radio controller driver") |
| Cc: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com> |
| Cc: David Vrabel <david.vrabel@csr.com> |
| Signed-off-by: Johan Hovold <johan@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| drivers/uwb/hwa-rc.c | 3 +++ |
| 1 file changed, 3 insertions(+) |
| |
| --- a/drivers/uwb/hwa-rc.c |
| +++ b/drivers/uwb/hwa-rc.c |
| @@ -811,6 +811,9 @@ static int hwarc_probe(struct usb_interf |
| struct hwarc *hwarc; |
| struct device *dev = &iface->dev; |
| |
| + if (iface->cur_altsetting->desc.bNumEndpoints < 1) |
| + return -ENODEV; |
| + |
| result = -ENOMEM; |
| uwb_rc = uwb_rc_alloc(); |
| if (uwb_rc == NULL) { |
