| From: Julia Lawall <Julia.Lawall@lip6.fr> |
| Date: Wed, 6 Jun 2018 15:03:22 +0200 |
| Subject: bnx2x: use the right constant |
| |
| commit dd612f18a49b63af8b3a5f572d999bdb197385bc upstream. |
| |
| Nearby code that also tests port suggests that the P0 constant should be |
| used when port is zero. |
| |
| The semantic match that finds this problem is as follows: |
| (http://coccinelle.lip6.fr/) |
| |
| // <smpl> |
| @@ |
| expression e,e1; |
| @@ |
| |
| * e ? e1 : e1 |
| // </smpl> |
| |
| Fixes: 6c3218c6f7e5 ("bnx2x: Adjust ETS to 578xx") |
| Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c |
| +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c |
| @@ -581,7 +581,7 @@ static void bnx2x_ets_e3b0_nig_disabled( |
| * slots for the highest priority. |
| */ |
| REG_WR(bp, (port) ? NIG_REG_P1_TX_ARB_NUM_STRICT_ARB_SLOTS : |
| - NIG_REG_P1_TX_ARB_NUM_STRICT_ARB_SLOTS, 0x100); |
| + NIG_REG_P0_TX_ARB_NUM_STRICT_ARB_SLOTS, 0x100); |
| /* Mapping between the CREDIT_WEIGHT registers and actual client |
| * numbers |
| */ |