| From: Arnd Bergmann <arnd@arndb.de> |
| Date: Thu, 11 May 2017 08:46:44 -0300 |
| Subject: [media] ir-core: fix gcc-7 warning on bool arithmetic |
| |
| commit bd7e31bbade02bc1e92aa00d5cf2cee2da66838a upstream. |
| |
| gcc-7 suggests that an expression using a bitwise not and a bitmask |
| on a 'bool' variable is better written using boolean logic: |
| |
| drivers/media/rc/imon.c: In function 'imon_incoming_scancode': |
| drivers/media/rc/imon.c:1725:22: error: '~' on a boolean expression [-Werror=bool-operation] |
| ictx->pad_mouse = ~(ictx->pad_mouse) & 0x1; |
| ^ |
| drivers/media/rc/imon.c:1725:22: note: did you mean to use logical not? |
| |
| I agree. |
| |
| Fixes: 21677cfc562a ("V4L/DVB: ir-core: add imon driver") |
| |
| Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| drivers/media/rc/imon.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/media/rc/imon.c |
| +++ b/drivers/media/rc/imon.c |
| @@ -1530,7 +1530,7 @@ static void imon_incoming_packet(struct |
| if (kc == KEY_KEYBOARD && !ictx->release_code) { |
| ictx->last_keycode = kc; |
| if (!nomouse) { |
| - ictx->pad_mouse = ~(ictx->pad_mouse) & 0x1; |
| + ictx->pad_mouse = !ictx->pad_mouse; |
| dev_dbg(dev, "toggling to %s mode\n", |
| ictx->pad_mouse ? "mouse" : "keyboard"); |
| spin_unlock_irqrestore(&ictx->kc_lock, flags); |
