| From: YueHaibing <yuehaibing@huawei.com> |
| Date: Thu, 19 Jul 2018 10:27:13 +0800 |
| Subject: net: caif: Add a missing rcu_read_unlock() in caif_flow_cb |
| |
| commit 64119e05f7b31e83e2555f6782e6cdc8f81c63f4 upstream. |
| |
| Add a missing rcu_read_unlock in the error path |
| |
| Fixes: c95567c80352 ("caif: added check for potential null return") |
| Signed-off-by: YueHaibing <yuehaibing@huawei.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| net/caif/caif_dev.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| --- a/net/caif/caif_dev.c |
| +++ b/net/caif/caif_dev.c |
| @@ -131,8 +131,10 @@ static void caif_flow_cb(struct sk_buff |
| caifd = caif_get(skb->dev); |
| |
| WARN_ON(caifd == NULL); |
| - if (caifd == NULL) |
| + if (!caifd) { |
| + rcu_read_unlock(); |
| return; |
| + } |
| |
| caifd_hold(caifd); |
| rcu_read_unlock(); |
