| From: Arnaldo Carvalho de Melo <acme@redhat.com> |
| Date: Wed, 8 Feb 2017 17:01:46 -0300 |
| Subject: perf top: Use __fallthrough |
| |
| commit 7b0214b702ad8e124e039a317beeebb3f020d125 upstream. |
| |
| The implicit fall through case label here is intended, so let us inform |
| that to gcc >= 7: |
| |
| CC /tmp/build/perf/builtin-top.o |
| builtin-top.c: In function 'display_thread': |
| builtin-top.c:644:7: error: this statement may fall through [-Werror=implicit-fallthrough=] |
| if (errno == EINTR) |
| ^ |
| builtin-top.c:647:3: note: here |
| default: |
| ^~~~~~~ |
| |
| Cc: Adrian Hunter <adrian.hunter@intel.com> |
| Cc: David Ahern <dsahern@gmail.com> |
| Cc: Jiri Olsa <jolsa@kernel.org> |
| Cc: Namhyung Kim <namhyung@kernel.org> |
| Cc: Wang Nan <wangnan0@huawei.com> |
| Link: http://lkml.kernel.org/n/tip-lmcfnnyx9ic0m6j0aud98p4e@git.kernel.org |
| Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| tools/perf/builtin-top.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/tools/perf/builtin-top.c |
| +++ b/tools/perf/builtin-top.c |
| @@ -609,7 +609,7 @@ repeat: |
| case -1: |
| if (errno == EINTR) |
| continue; |
| - /* Fall trhu */ |
| + __fallthrough; |
| default: |
| c = getc(stdin); |
| tcsetattr(0, TCSAFLUSH, &save); |