| From: "Li, Liang Z" <liang.z.li@intel.com> |
| Date: Sat, 27 Jun 2015 07:17:26 +0800 |
| Subject: xen-netfront: Remove the meaningless code |
| |
| commit 905726c1c5a3ca620ba7d73c78eddfb91de5ce28 upstream. |
| |
| The function netif_set_real_num_tx_queues() will return -EINVAL if |
| the second parameter < 1, so call this function with the second |
| parameter set to 0 is meaningless. |
| |
| Signed-off-by: Liang Li <liang.z.li@intel.com> |
| Reviewed-by: David Vrabel <david.vrabel@citrix.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| drivers/net/xen-netfront.c | 7 ------- |
| 1 file changed, 7 deletions(-) |
| |
| --- a/drivers/net/xen-netfront.c |
| +++ b/drivers/net/xen-netfront.c |
| @@ -1330,10 +1330,6 @@ static struct net_device *xennet_create_ |
| np = netdev_priv(netdev); |
| np->xbdev = dev; |
| |
| - /* No need to use rtnl_lock() before the call below as it |
| - * happens before register_netdev(). |
| - */ |
| - netif_set_real_num_tx_queues(netdev, 0); |
| np->queues = NULL; |
| |
| err = -ENOMEM; |
| @@ -1992,9 +1988,6 @@ abort_transaction_no_dev_fatal: |
| xennet_disconnect_backend(info); |
| kfree(info->queues); |
| info->queues = NULL; |
| - rtnl_lock(); |
| - netif_set_real_num_tx_queues(info->netdev, 0); |
| - rtnl_unlock(); |
| out: |
| return err; |
| } |
