| From: Boris Ostrovsky <boris.ostrovsky@oracle.com> |
| Date: Thu, 21 Jun 2018 13:29:44 -0400 |
| Subject: xen: Remove unnecessary BUG_ON from __unbind_from_irq() |
| |
| commit eef04c7b3786ff0c9cb1019278b6c6c2ea0ad4ff upstream. |
| |
| Commit 910f8befdf5b ("xen/pirq: fix error path cleanup when binding |
| MSIs") fixed a couple of errors in error cleanup path of |
| xen_bind_pirq_msi_to_irq(). This cleanup allowed a call to |
| __unbind_from_irq() with an unbound irq, which would result in |
| triggering the BUG_ON there. |
| |
| Since there is really no reason for the BUG_ON (xen_free_irq() can |
| operate on unbound irqs) we can remove it. |
| |
| Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk> |
| Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> |
| Reviewed-by: Juergen Gross <jgross@suse.com> |
| Signed-off-by: Juergen Gross <jgross@suse.com> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| drivers/xen/events/events_base.c | 2 -- |
| 1 file changed, 2 deletions(-) |
| |
| --- a/drivers/xen/events/events_base.c |
| +++ b/drivers/xen/events/events_base.c |
| @@ -636,8 +636,6 @@ static void __unbind_from_irq(unsigned i |
| xen_irq_info_cleanup(info); |
| } |
| |
| - BUG_ON(info_for_irq(irq)->type == IRQT_UNBOUND); |
| - |
| xen_free_irq(irq); |
| } |
| |
