| From: Jian-Hong Pan <jian-hong@endlessm.com> |
| Date: Mon, 30 Dec 2019 16:30:45 +0800 |
| Subject: platform/x86: asus-wmi: Fix keyboard brightness cannot be set to 0 |
| |
| commit 176a7fca81c5090a7240664e3002c106d296bf31 upstream. |
| |
| Some of ASUS laptops like UX431FL keyboard backlight cannot be set to |
| brightness 0. According to ASUS' information, the brightness should be |
| 0x80 ~ 0x83. This patch fixes it by following the logic. |
| |
| Fixes: e9809c0b9670 ("asus-wmi: add keyboard backlight support") |
| Signed-off-by: Jian-Hong Pan <jian-hong@endlessm.com> |
| Reviewed-by: Daniel Drake <drake@endlessm.com> |
| Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| drivers/platform/x86/asus-wmi.c | 8 +------- |
| 1 file changed, 1 insertion(+), 7 deletions(-) |
| |
| --- a/drivers/platform/x86/asus-wmi.c |
| +++ b/drivers/platform/x86/asus-wmi.c |
| @@ -386,13 +386,7 @@ static void kbd_led_update(struct work_s |
| |
| asus = container_of(work, struct asus_wmi, kbd_led_work); |
| |
| - /* |
| - * bits 0-2: level |
| - * bit 7: light on/off |
| - */ |
| - if (asus->kbd_led_wk > 0) |
| - ctrl_param = 0x80 | (asus->kbd_led_wk & 0x7F); |
| - |
| + ctrl_param = 0x80 | (asus->kbd_led_wk & 0x7F); |
| asus_wmi_set_devstate(ASUS_WMI_DEVID_KBD_BACKLIGHT, ctrl_param, NULL); |
| } |
| |
