| From: Andrew Morton <akpm@linux-foundation.org> |
| Date: Tue, 10 Apr 2018 16:34:41 -0700 |
| Subject: fs/reiserfs/journal.c: add missing resierfs_warning() arg |
| |
| commit 9ad553abe66f8be3f4755e9fa0a6ba137ce76341 upstream. |
| |
| One use of the reiserfs_warning() macro in journal_init_dev() is missing |
| a parameter, causing the following warning: |
| |
| REISERFS warning (device loop0): journal_init_dev: Cannot open '%s': %i journal_init_dev: |
| |
| This also causes a WARN_ONCE() warning in the vsprintf code, and then a |
| panic if panic_on_warn is set. |
| |
| Please remove unsupported %/ in format string |
| WARNING: CPU: 1 PID: 4480 at lib/vsprintf.c:2138 format_decode+0x77f/0x830 lib/vsprintf.c:2138 |
| Kernel panic - not syncing: panic_on_warn set ... |
| |
| Just add another string argument to the macro invocation. |
| |
| Addresses https://syzkaller.appspot.com/bug?id=0627d4551fdc39bf1ef5d82cd9eef587047f7718 |
| |
| Link: http://lkml.kernel.org/r/d678ebe1-6f54-8090-df4c-b9affad62293@infradead.org |
| Signed-off-by: Randy Dunlap <rdunlap@infradead.org> |
| Reported-by: <syzbot+6bd77b88c1977c03f584@syzkaller.appspotmail.com> |
| Tested-by: Randy Dunlap <rdunlap@infradead.org> |
| Acked-by: Jeff Mahoney <jeffm@suse.com> |
| Cc: Alexander Viro <viro@zeniv.linux.org.uk> |
| Cc: Jan Kara <jack@suse.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| fs/reiserfs/journal.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/fs/reiserfs/journal.c |
| +++ b/fs/reiserfs/journal.c |
| @@ -2641,7 +2641,7 @@ static int journal_init_dev(struct super |
| if (IS_ERR(journal->j_dev_bd)) { |
| result = PTR_ERR(journal->j_dev_bd); |
| journal->j_dev_bd = NULL; |
| - reiserfs_warning(super, |
| + reiserfs_warning(super, "sh-457", |
| "journal_init_dev: Cannot open '%s': %i", |
| jdev_name, result); |
| return result; |
