| From: Dmitry Safonov <dsafonov@virtuozzo.com> |
| Date: Thu, 25 Aug 2016 18:21:09 +0300 |
| Subject: tracing/uprobe: Drop isdigit() check in create_trace_uprobe |
| |
| commit 5ba8a4a96f6eaa6af88e24c7794f142217aa3b6f upstream. |
| |
| It's useless. Before: |
| [tracing]# echo 'p:test /a:0x0' >> uprobe_events |
| [tracing]# echo 'p:test a:0x0' >> uprobe_events |
| -bash: echo: write error: No such file or directory |
| [tracing]# echo 'p:test 1:0x0' >> uprobe_events |
| -bash: echo: write error: Invalid argument |
| |
| After: |
| [tracing]# echo 'p:test 1:0x0' >> uprobe_events |
| -bash: echo: write error: No such file or directory |
| |
| Link: http://lkml.kernel.org/r/20160825152110.25663-3-dsafonov@virtuozzo.com |
| |
| Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com> |
| Acked-by: Oleg Nesterov <oleg@redhat.com> |
| Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com> |
| Signed-off-by: Steven Rostedt <rostedt@goodmis.org> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| kernel/trace/trace_uprobe.c | 4 ---- |
| 1 file changed, 4 deletions(-) |
| |
| --- a/kernel/trace/trace_uprobe.c |
| +++ b/kernel/trace/trace_uprobe.c |
| @@ -430,10 +430,6 @@ static int create_trace_uprobe(int argc, |
| pr_info("Probe point is not specified.\n"); |
| return -EINVAL; |
| } |
| - if (isdigit(argv[1][0])) { |
| - pr_info("probe point must be have a filename.\n"); |
| - return -EINVAL; |
| - } |
| arg = strchr(argv[1], ':'); |
| if (!arg) { |
| ret = -EINVAL; |
