| From: Chao Yu <chao2.yu@samsung.com> |
| Date: Sat, 9 Aug 2014 09:49:31 +0800 |
| Subject: udf: avoid unneeded up_write when fail to add entry in ->symlink |
| |
| commit 85cd083b498572fb9fa575cce3ed910c8ee84294 upstream. |
| |
| We have released the ->i_data_sem before invoking udf_add_entry(), |
| so in following error path, we should not release this lock again. |
| |
| Signed-off-by: Chao Yu <chao2.yu@samsung.com> |
| Signed-off-by: Jan Kara <jack@suse.cz> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| fs/udf/namei.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/fs/udf/namei.c |
| +++ b/fs/udf/namei.c |
| @@ -1015,7 +1015,7 @@ static int udf_symlink(struct inode *dir |
| |
| fi = udf_add_entry(dir, dentry, &fibh, &cfi, &err); |
| if (!fi) |
| - goto out_no_entry; |
| + goto out_fail; |
| cfi.icb.extLength = cpu_to_le32(sb->s_blocksize); |
| cfi.icb.extLocation = cpu_to_lelb(iinfo->i_location); |
| if (UDF_SB(inode->i_sb)->s_lvid_bh) { |
| @@ -1037,6 +1037,7 @@ out: |
| |
| out_no_entry: |
| up_write(&iinfo->i_data_sem); |
| +out_fail: |
| inode_dec_link_count(inode); |
| iput(inode); |
| goto out; |
