| From: Thinh Nguyen <Thinh.Nguyen@synopsys.com> |
| Date: Mon, 19 Mar 2018 13:07:35 -0700 |
| Subject: usb: dwc3: pci: Properly cleanup resource |
| |
| commit cabdf83dadfb3d83eec31e0f0638a92dbd716435 upstream. |
| |
| Platform device is allocated before adding resources. Make sure to |
| properly cleanup on error case. |
| |
| Fixes: f1c7e7108109 ("usb: dwc3: convert to pcim_enable_device()") |
| Signed-off-by: Thinh Nguyen <thinhn@synopsys.com> |
| Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com> |
| [bwh: Backported to 3.16: Cleanup label is called "err3"] |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| drivers/usb/dwc3/dwc3-pci.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/usb/dwc3/dwc3-pci.c |
| +++ b/drivers/usb/dwc3/dwc3-pci.c |
| @@ -144,7 +144,7 @@ static int dwc3_pci_probe(struct pci_dev |
| ret = platform_device_add_resources(dwc3, res, ARRAY_SIZE(res)); |
| if (ret) { |
| dev_err(dev, "couldn't add resources to dwc3 device\n"); |
| - return ret; |
| + goto err3; |
| } |
| |
| pci_set_drvdata(pci, glue); |
