| From 5289ea4234e0a47ef04a44cef8ea71a7b656cfdc Mon Sep 17 00:00:00 2001 |
| From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> |
| Date: Tue, 17 Jan 2017 10:28:53 +0200 |
| Subject: [PATCH 238/255] drm: bridge: dw-hdmi: Remove unused function |
| parameter |
| |
| The 'prep' parameter passed to hdmi_phy_configure() is useless. It is |
| hardcoded as 0, and if set, simply prevents the configure function from |
| executing. |
| |
| Remove it. |
| |
| Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> |
| Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> |
| Reviewed-by: Jose Abreu <joabreu@synopsys.com> |
| Signed-off-by: Archit Taneja <architt@codeaurora.org> |
| Link: http://patchwork.freedesktop.org/patch/msgid/20170117082910.27023-4-laurent.pinchart+renesas@ideasonboard.com |
| (cherry picked from commit dfa73065d61b6ce57aed90bb0d745c4b6f5b71e7) |
| Signed-off-by: Simon Horman <horms+renesas@verge.net.au> |
| --- |
| drivers/gpu/drm/bridge/dw-hdmi.c | 7 ++----- |
| 1 file changed, 2 insertions(+), 5 deletions(-) |
| |
| --- a/drivers/gpu/drm/bridge/dw-hdmi.c |
| +++ b/drivers/gpu/drm/bridge/dw-hdmi.c |
| @@ -931,7 +931,7 @@ static void dw_hdmi_phy_sel_interface_co |
| HDMI_PHY_CONF0_SELDIPIF_MASK); |
| } |
| |
| -static int hdmi_phy_configure(struct dw_hdmi *hdmi, unsigned char prep, |
| +static int hdmi_phy_configure(struct dw_hdmi *hdmi, |
| unsigned char res, int cscon) |
| { |
| unsigned res_idx; |
| @@ -941,9 +941,6 @@ static int hdmi_phy_configure(struct dw_ |
| const struct dw_hdmi_curr_ctrl *curr_ctrl = pdata->cur_ctr; |
| const struct dw_hdmi_phy_config *phy_config = pdata->phy_config; |
| |
| - if (prep) |
| - return -EINVAL; |
| - |
| switch (res) { |
| case 0: /* color resolution 0 is 8 bit colour depth */ |
| case 8: |
| @@ -1072,7 +1069,7 @@ static int dw_hdmi_phy_init(struct dw_hd |
| dw_hdmi_phy_enable_powerdown(hdmi, true); |
| |
| /* Enable CSC */ |
| - ret = hdmi_phy_configure(hdmi, 0, 8, cscon); |
| + ret = hdmi_phy_configure(hdmi, 8, cscon); |
| if (ret) |
| return ret; |
| } |
